src/api.cc - Issue 1325643002: [heap] Fix recursive GCs caused by adjusting externally allocated memory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 1325643002: [heap] Fix recursive GCs caused by adjusting externally allocated memory (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comment Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 42a887582723524f4773847d51cdb2da5f58827a..d2ad3069dd3106b11acf22b8396fc3e42d9ba292 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -6873,6 +6873,7 @@ Local<Integer> v8::Integer::NewFromUnsigned(Isolate* isolate, uint32_t value) {

void Isolate::CollectAllGarbage(const char* gc_reason) {

i::Heap* heap = reinterpret_cast<i::Isolate*>(this)->heap();

+ DCHECK_EQ(heap->gc_state(), i::Heap::NOT_IN_GC);

if (heap->incremental_marking()->IsStopped()) {

if (heap->incremental_marking()->CanBeActivated()) {

heap->StartIncrementalMarking(

« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | src/heap/heap.cc » ('J')