[runtime] Replace many buggy uses of %_CallFunction with %_Call.

[runtime] Replace many buggy uses of %_CallFunction with %_Call.

The semantics of the %_CallFunction intrinsic seem to be very unclear,
which resulted in a lot of bugs. Especially the combination with
%IsSloppyModeFunction is always a bug, because the receiver would be
wrapped in the wrong context. So the %IsSloppyModeFunction helper is
gone now, and many of the buggy uses of %_CallFunction are also
eliminated.

If you ever need to call something with a different receiver, then
%_Call is your friend now. It does what you want and implements the
call sequence fully (and correct).

BUG=v8:4413
LOG=n

Committed: https://crrev.com/db2ba190dba6983b94eae36e111b0feebb97587e
Cr-Commit-Position: refs/heads/master@{#30634}

[Benedikt Meurer, 2015-09-08 10:50:12]

bmeurer@chromium.org changed reviewers:
+ jarin@chromium.org

[Benedikt Meurer, 2015-09-08 10:50:12]

Hey Jaro, Camillo,

This is the initial part of the %_CallFunction fixification.
Please take a look.

Thanks,
Benedikt

[Benedikt Meurer, 2015-09-08 10:50:50]

bmeurer@chromium.org changed reviewers:
+ cbruni@chromium.org

[Jarin, 2015-09-08 11:10:07]

lgtm

[Camillo Bruni, 2015-09-08 11:19:13]

JS-part: lgtm

https://codereview.chromium.org/1325573004/diff/20001/src/arm/interface-descr...
File src/arm/interface-descriptors-arm.cc (right):

https://codereview.chromium.org/1325573004/diff/20001/src/arm/interface-descr...
src/arm/interface-descriptors-arm.cc:196: CallInterfaceDescriptorData* data) {
// r1: target
// r0: number of arguments

https://codereview.chromium.org/1325573004/diff/20001/src/ia32/interface-desc...
File src/ia32/interface-descriptors-ia32.cc (right):

https://codereview.chromium.org/1325573004/diff/20001/src/ia32/interface-desc...
src/ia32/interface-descriptors-ia32.cc:202: CallInterfaceDescriptorData* data) {
// edi: target
// eax: number of arguments

https://codereview.chromium.org/1325573004/diff/20001/src/object-observe.js
File src/object-observe.js (right):

https://codereview.chromium.org/1325573004/diff/20001/src/object-observe.js#n...
src/object-observe.js:604: changeRecord = %_Call(changeFn, UNDEFINED);
changeFn() ?

https://codereview.chromium.org/1325573004/diff/20001/src/x64/interface-descr...
File src/x64/interface-descriptors-x64.cc (right):

https://codereview.chromium.org/1325573004/diff/20001/src/x64/interface-descr...
src/x64/interface-descriptors-x64.cc:195: CallInterfaceDescriptorData* data) {
// rdi: target
// rax: number of arguments

[Camillo Bruni, 2015-09-08 12:32:58]

minor improvements

https://codereview.chromium.org/1325573004/diff/40001/src/array.js
File src/array.js (right):

https://codereview.chromium.org/1325573004/diff/40001/src/array.js#newcode925
src/array.js:925: return comparefn(a[1], b[1]);
We can rid of this %_CallFunction by using an InternalArray for t_array and then
just t_array.sort(function(...){...})

[Benedikt Meurer, 2015-09-08 13:08:58]

https://codereview.chromium.org/1325573004/diff/20001/src/arm/interface-descr...
File src/arm/interface-descriptors-arm.cc (right):

https://codereview.chromium.org/1325573004/diff/20001/src/arm/interface-descr...
src/arm/interface-descriptors-arm.cc:196: CallInterfaceDescriptorData* data) {
On 2015/09/08 11:19:13, cbruni wrote:
> // r1: target
> // r0: number of arguments

Done.

https://codereview.chromium.org/1325573004/diff/20001/src/ia32/interface-desc...
File src/ia32/interface-descriptors-ia32.cc (right):

https://codereview.chromium.org/1325573004/diff/20001/src/ia32/interface-desc...
src/ia32/interface-descriptors-ia32.cc:202: CallInterfaceDescriptorData* data) {
On 2015/09/08 11:19:13, cbruni wrote:
> // edi: target
> // eax: number of arguments

Done.

https://codereview.chromium.org/1325573004/diff/20001/src/object-observe.js
File src/object-observe.js (right):

https://codereview.chromium.org/1325573004/diff/20001/src/object-observe.js#n...
src/object-observe.js:604: changeRecord = %_Call(changeFn, UNDEFINED);
On 2015/09/08 11:19:13, cbruni wrote:
> changeFn() ?

Done.

https://codereview.chromium.org/1325573004/diff/20001/src/x64/interface-descr...
File src/x64/interface-descriptors-x64.cc (right):

https://codereview.chromium.org/1325573004/diff/20001/src/x64/interface-descr...
src/x64/interface-descriptors-x64.cc:195: CallInterfaceDescriptorData* data) {
On 2015/09/08 11:19:13, cbruni wrote:
> // rdi: target
> // rax: number of arguments

Done.

https://codereview.chromium.org/1325573004/diff/40001/src/array.js
File src/array.js (right):

https://codereview.chromium.org/1325573004/diff/40001/src/array.js#newcode925
src/array.js:925: return comparefn(a[1], b[1]);
Doable, but in a separate CL.

[Benedikt Meurer, 2015-09-08 13:09:45]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-09-08 13:09:45]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org,
cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/1325573004/#ps60001
(title: "Address feedback.")

[commit-bot: I haz the power, 2015-09-08 13:09:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1325573004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1325573004/60001

[commit-bot: I haz the power, 2015-09-08 13:35:26]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-08 13:35:41]

Patchset 4 (id:??) landed as
https://crrev.com/db2ba190dba6983b94eae36e111b0feebb97587e
Cr-Commit-Position: refs/heads/master@{#30634}