Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: src/json.js

Issue 1325573004: [runtime] Replace many buggy uses of %_CallFunction with %_Call. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address feedback. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interface-descriptors.cc ('k') | src/macros.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/json.js
diff --git a/src/json.js b/src/json.js
index 5ddf869ae0a9a15b3d9e19caf7437e84261649a3..a0a88a04c1abf86b8fcea1ec23958c9da43f79d2 100644
--- a/src/json.js
+++ b/src/json.js
@@ -52,7 +52,7 @@ function Revive(holder, name, reviver) {
}
}
}
- return %_CallFunction(holder, name, val, reviver);
+ return %_Call(reviver, holder, name, val);
}
@@ -147,11 +147,11 @@ function JSONSerialize(key, holder, replacer, stack, indent, gap) {
if (IS_SPEC_OBJECT(value)) {
var toJSON = value.toJSON;
if (IS_CALLABLE(toJSON)) {
- value = %_CallFunction(value, key, toJSON);
+ value = %_Call(toJSON, value, key);
}
}
if (IS_CALLABLE(replacer)) {
- value = %_CallFunction(holder, key, value, replacer);
+ value = %_Call(replacer, holder, key, value);
}
if (IS_STRING(value)) {
return %QuoteJSONString(value);
« no previous file with comments | « src/interface-descriptors.cc ('k') | src/macros.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698