Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1325143004: ServiceWorker: Drop statechange events if WebServiceWorkerProxy is not ready (Closed)

Created:
5 years, 3 months ago by nhiroki
Modified:
5 years, 3 months ago
Reviewers:
Kunihiko Sakamoto
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Drop statechange events if WebServiceWorkerProxy is not ready This is a quick fix for http://crbug.com/507110 BUG=507110 Committed: https://crrev.com/3ded5b9d6d175d8f243390f81296e2c4ea6a80fa Cr-Commit-Position: refs/heads/master@{#347878}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M content/child/service_worker/web_service_worker_impl.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
nhiroki
PTAL, thanks!
5 years, 3 months ago (2015-09-09 07:42:17 UTC) #2
Kunihiko Sakamoto
lgtm
5 years, 3 months ago (2015-09-09 07:47:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325143004/1
5 years, 3 months ago (2015-09-09 08:03:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 09:12:09 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 09:13:04 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3ded5b9d6d175d8f243390f81296e2c4ea6a80fa
Cr-Commit-Position: refs/heads/master@{#347878}

Powered by Google App Engine
This is Rietveld 408576698