Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Unified Diff: content/child/service_worker/web_service_worker_impl.cc

Issue 1325143004: ServiceWorker: Drop statechange events if WebServiceWorkerProxy is not ready (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/service_worker/web_service_worker_impl.cc
diff --git a/content/child/service_worker/web_service_worker_impl.cc b/content/child/service_worker/web_service_worker_impl.cc
index f856cf82aedb3980fa9d2fd027f7c8ae629c2acd..f7e111c2f342d9aae1772e1c4aa39072b08d727d 100644
--- a/content/child/service_worker/web_service_worker_impl.cc
+++ b/content/child/service_worker/web_service_worker_impl.cc
@@ -58,7 +58,11 @@ WebServiceWorkerImpl::~WebServiceWorkerImpl() {
void WebServiceWorkerImpl::OnStateChanged(
blink::WebServiceWorkerState new_state) {
state_ = new_state;
- proxy_->dispatchStateChangeEvent();
+
+ // TODO(nhiroki): This is a quick fix for http://crbug.com/507110
+ DCHECK(proxy_);
+ if (proxy_)
+ proxy_->dispatchStateChangeEvent();
}
void WebServiceWorkerImpl::setProxy(blink::WebServiceWorkerProxy* proxy) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698