Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1325143002: [Android] Move Android version codes into devil/. (Closed)

Created:
5 years, 3 months ago by jbudorick
Modified:
5 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, telemetry-reviews_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Move Android version codes into devil/. BUG=476719 Committed: https://crrev.com/d292c5b969fcf7950e82653b88a0ff225a1c5a24 Cr-Commit-Position: refs/heads/master@{#347074}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -63 lines) Patch
M build/android/devil/android/battery_utils.py View 3 chunks +3 lines, -4 lines 0 comments Download
M build/android/devil/android/device_utils.py View 10 chunks +11 lines, -14 lines 0 comments Download
M build/android/devil/android/device_utils_test.py View 5 chunks +9 lines, -8 lines 0 comments Download
A build/android/devil/android/sdk/version_codes.py View 1 chunk +18 lines, -0 lines 0 comments Download
M build/android/devil/utils/mock_calls_test.py View 3 chunks +6 lines, -8 lines 0 comments Download
M build/android/provision_devices.py View 4 chunks +6 lines, -6 lines 0 comments Download
M build/android/pylib/constants/__init__.py View 1 3 chunks +8 lines, -19 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/android_platform_backend.py View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jbudorick
5 years, 3 months ago (2015-09-02 22:37:58 UTC) #2
nednguyen
lgtm
5 years, 3 months ago (2015-09-02 22:50:34 UTC) #3
rnephew (Reviews Here)
On 2015/09/02 22:37:58, jbudorick wrote: lgtm
5 years, 3 months ago (2015-09-02 22:51:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325143002/20001
5 years, 3 months ago (2015-09-02 22:52:00 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-03 00:40:31 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 00:41:31 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d292c5b969fcf7950e82653b88a0ff225a1c5a24
Cr-Commit-Position: refs/heads/master@{#347074}

Powered by Google App Engine
This is Rietveld 408576698