[Android] Move Android version codes into devil/.

build/android/devil/android/device_utils.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Provides a variety of device interactions based on adb.
 
 Eventually, this will be based on adb_wrapper.
 """
 # pylint: disable=unused-argument
 
@@ skipping 18 matching lines @@
 from devil.android import decorators
 from devil.android import device_blacklist
 from devil.android import device_errors
 from devil.android import device_temp_file
 from devil.android import logcat_monitor
 from devil.android import md5sum
 from devil.android.sdk import adb_wrapper
 from devil.android.sdk import intent
 from devil.android.sdk import keyevent
 from devil.android.sdk import split_select
+from devil.android.sdk import version_codes
 from devil.utils import host_utils
 from devil.utils import parallelizer
 from devil.utils import reraiser_thread
 from devil.utils import timeout_retry
 from devil.utils import zip_utils
 from pylib import constants
 from pylib.device.commands import install_commands
 
 _DEFAULT_TIMEOUT = 30
 _DEFAULT_RETRIES = 3
@@ skipping 99 matching lines @@
 
 
 class DeviceUtils(object):
 
   _MAX_ADB_COMMAND_LENGTH = 512
   _MAX_ADB_OUTPUT_LENGTH = 32768
   _LAUNCHER_FOCUSED_RE = re.compile(
       '\s*mCurrentFocus.*(Launcher|launcher).*')
   _VALID_SHELL_VARIABLE = re.compile('^[a-zA-Z_][a-zA-Z0-9_]*$')
 
+  LOCAL_PROPERTIES_PATH = posixpath.join('/', 'data', 'local.prop')
+
   # Property in /data/local.prop that controls Java assertions.
   JAVA_ASSERT_PROPERTY = 'dalvik.vm.enableassertions'
 
   def __init__(self, device, default_timeout=_DEFAULT_TIMEOUT,
                default_retries=_DEFAULT_RETRIES):
     """DeviceUtils constructor.
 
     Args:
       device: Either a device serial, an existing AdbWrapper instance, or an
               an existing AndroidCommands instance.
@@ skipping 111 matching lines @@
         self.RunShellCommand(
             '%s && ! ls /root' % self._Su('ls /root'), check_return=True,
             timeout=self._default_timeout if timeout is DEFAULT else timeout,
             retries=self._default_retries if retries is DEFAULT else retries)
         self._cache['needs_su'] = True
       except device_errors.AdbCommandFailedError:
         self._cache['needs_su'] = False
     return self._cache['needs_su']
 
   def _Su(self, command):
-    if (self.build_version_sdk
-        >= constants.ANDROID_SDK_VERSION_CODES.MARSHMALLOW):
+    if (self.build_version_sdk >= version_codes.MARSHMALLOW):
       return 'su 0 %s' % command
     return 'su -c %s' % command
 
   @decorators.WithTimeoutAndRetriesFromInstance()
   def EnableRoot(self, timeout=None, retries=None):
     """Restarts adbd with root privileges.
 
     Args:
       timeout: timeout in seconds
       retries: number of retries
@@ skipping 69 matching lines @@
     return self._GetApplicationPathsInternal(package)
 
   def _GetApplicationPathsInternal(self, package, skip_cache=False):
     cached_result = self._cache['package_apk_paths'].get(package)
     if cached_result is not None and not skip_cache:
       return list(cached_result)
     # 'pm path' is liable to incorrectly exit with a nonzero number starting
     # in Lollipop.
     # TODO(jbudorick): Check if this is fixed as new Android versions are
     # released to put an upper bound on this.
-    should_check_return = (self.build_version_sdk <
-                           constants.ANDROID_SDK_VERSION_CODES.LOLLIPOP)
+    should_check_return = (self.build_version_sdk < version_codes.LOLLIPOP)
     output = self.RunShellCommand(
         ['pm', 'path', package], check_return=should_check_return)
     apks = []
     for line in output:
       if not line.startswith('package:'):
         raise device_errors.CommandFailedError(
             'pm path returned: %r' % '\n'.join(output), str(self))
       apks.append(line[len('package:'):])
     self._cache['package_apk_paths'][package] = list(apks)
     return apks
@@ skipping 176 matching lines @@
       reinstall: A boolean indicating if we should keep any existing app data.
       timeout: timeout in seconds
       retries: number of retries
 
     Raises:
       CommandFailedError if the installation fails.
       CommandTimeoutError if the installation times out.
       DeviceUnreachableError on missing device.
       DeviceVersionError if device SDK is less than Android L.
     """
-    self._CheckSdkLevel(constants.ANDROID_SDK_VERSION_CODES.LOLLIPOP)
+    self._CheckSdkLevel(version_codes.LOLLIPOP)
 
     all_apks = [base_apk] + split_select.SelectSplits(
         self, base_apk, split_apks)
     package_name = apk_helper.GetPackageName(base_apk)
     device_apk_paths = self._GetApplicationPathsInternal(package_name)
 
     if device_apk_paths:
       partial_install_package = package_name
       apks_to_install, host_checksums = (
           self._ComputeStaleApks(package_name, all_apks))
@@ skipping 388 matching lines @@
       timeout: timeout in seconds
       retries: number of retries
 
     Raises:
       CommandTimeoutError on timeout.
       DeviceUnreachableError on missing device.
     """
     # Check that the package exists before clearing it for android builds below
     # JB MR2. Necessary because calling pm clear on a package that doesn't exist
     # may never return.
-    if ((self.build_version_sdk >=
-         constants.ANDROID_SDK_VERSION_CODES.JELLY_BEAN_MR2)
+    if ((self.build_version_sdk >= version_codes.JELLY_BEAN_MR2)
         or self._GetApplicationPathsInternal(package)):
       self.RunShellCommand(['pm', 'clear', package], check_return=True)
 
   @decorators.WithTimeoutAndRetriesFromInstance()
   def SendKeyEvent(self, keycode, timeout=None, retries=None):
     """Sends a keycode to the device.
 
-    See the pylib.constants.keyevent module for suitable keycode values.
+    See the devil.android.sdk.keyevent module for suitable keycode values.
 
     Args:
       keycode: A integer keycode to send to the device.
       timeout: timeout in seconds
       retries: number of retries
 
     Raises:
       CommandTimeoutError on timeout.
       DeviceUnreachableError on missing device.
     """
@@ skipping 463 matching lines @@
           continue
         key, value = (s.strip() for s in line.split('=', 1))
         if key == property_name:
           return index, value
       return None, ''
 
     new_value = 'all' if enabled else ''
 
     # First ensure the desired property is persisted.
     try:
-      properties = self.ReadFile(
-          constants.DEVICE_LOCAL_PROPERTIES_PATH).splitlines()
+      properties = self.ReadFile(self.LOCAL_PROPERTIES_PATH).splitlines()
     except device_errors.CommandFailedError:
       properties = []
     index, value = find_property(properties, self.JAVA_ASSERT_PROPERTY)
     if new_value != value:
       if new_value:
         new_line = '%s=%s' % (self.JAVA_ASSERT_PROPERTY, new_value)
         if index is None:
           properties.append(new_line)
         else:
           properties[index] = new_line
       else:
         assert index is not None # since new_value == '' and new_value != value
         properties.pop(index)
-      self.WriteFile(constants.DEVICE_LOCAL_PROPERTIES_PATH,
-                     _JoinLines(properties))
+      self.WriteFile(self.LOCAL_PROPERTIES_PATH, _JoinLines(properties))
 
     # Next, check the current runtime value is what we need, and
     # if not, set it and report that a reboot is required.
     value = self.GetProp(self.JAVA_ASSERT_PROPERTY)
     if new_value != value:
       self.SetProp(self.JAVA_ASSERT_PROPERTY, new_value)
       return True
     else:
       return False
 
@@ skipping 54 matching lines @@
     """Returns the build type of the system (e.g. 'user')."""
     return self.GetProp('ro.build.type', cache=True)
 
   @property
   def build_version_sdk(self):
     """Returns the build version sdk of the system as a number (e.g. 19).
 
     For version code numbers see:
     http://developer.android.com/reference/android/os/Build.VERSION_CODES.html
 
-    For named constants see:
-    pylib.constants.ANDROID_SDK_VERSION_CODES
+    For named constants see devil.android.sdk.version_codes
 
     Raises:
       CommandFailedError if the build version sdk is not a number.
     """
     value = self.GetProp('ro.build.version.sdk', cache=True)
     try:
       return int(value)
     except ValueError:
       raise device_errors.CommandFailedError(
           'Invalid build version sdk: %r' % value)
@@ skipping 327 matching lines @@
     return [cls(adb, **kwargs) for adb in adb_wrapper.AdbWrapper.Devices()
             if not blacklisted(adb)]
 
   @decorators.WithTimeoutAndRetriesFromInstance()
   def RestartAdbd(self, timeout=None, retries=None):
     logging.info('Restarting adbd on device.')
     with device_temp_file.DeviceTempFile(self.adb, suffix='.sh') as script:
       self.WriteFile(script.name, _RESTART_ADBD_SCRIPT)
       self.RunShellCommand(['source', script.name], as_root=True)
       self.adb.WaitForDevice()