Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 132493002: [Sheriff] Revert "Templatise type representation" and "Fix Mac warnings". (Closed)

Created:
6 years, 11 months ago by Michael Achenbach
Modified:
6 years, 11 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

[Sheriff] Revert "Templatise type representation" and "Fix Mac warnings". This reverts commit r18521 and r18522 for breaking mac and win builders. BUG= TBR=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18524

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+557 lines, -638 lines) Patch
M src/ast.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ast.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.cc View 2 chunks +11 lines, -10 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 8 chunks +14 lines, -12 lines 0 comments Download
M src/ic.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ic.cc View 7 chunks +38 lines, -30 lines 0 comments Download
M src/list.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/objects.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M src/property-details.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/type-info.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/types.h View 5 chunks +105 lines, -173 lines 0 comments Download
M src/types.cc View 16 chunks +183 lines, -216 lines 0 comments Download
M src/typing.cc View 13 chunks +34 lines, -33 lines 0 comments Download
M test/cctest/test-types.cc View 27 chunks +149 lines, -138 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Achenbach
PTAL
6 years, 11 months ago (2014-01-09 19:51:27 UTC) #1
Michael Achenbach
6 years, 11 months ago (2014-01-09 19:52:29 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r18524.

Powered by Google App Engine
This is Rietveld 408576698