Paint invalidation tests for slimming paint v2

Paint invalidation tests for slimming paint v2

Add a new type of paint invalidation test for slimming paint v2.

- They are reftests, to check the correctness of painted result;
- Tracks paint invalidation objects and checks them against expected
  list.

This CL converts two paint/invalidation tests into the new style.

Will convert some fast/repaint and compositing/repaint tests into this
style for spv2 after this CL. The original tests are not suitable for
spv2 because
- it's hard to determine if a test is actually failing or needs
  rebaseline for spv2;
- they don't cover correctness of paint results.

BUG=524134
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201565

[Xianzhu, 2015-08-31 20:59:51]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org, pdr@chromium.org

[chrishtr, 2015-08-31 22:52:19]

https://codereview.chromium.org/1324763002/diff/1/LayoutTests/paint/invalidat...
File LayoutTests/paint/invalidation/spv2/invalidate-after-composited-scroll.html
(right):

https://codereview.chromium.org/1324763002/diff/1/LayoutTests/paint/invalidat...
LayoutTests/paint/invalidation/spv2/invalidate-after-composited-scroll.html:13:
// TODO(wangxianzhu): We should invalidate target (perhaps also the scrollbar)
only.
These results look wrong. The spacers etc should not invalidate, right?

https://codereview.chromium.org/1324763002/diff/1/Source/core/testing/Interna...
File Source/core/testing/Internals.idl (right):

https://codereview.chromium.org/1324763002/diff/1/Source/core/testing/Interna...
Source/core/testing/Internals.idl:247: // 
startTrackingPaintInvalidationObjects, paintInvalidationObjects,
stopTrackingPaintInvalidationObjects.
Add a comment that trackedPaintInvalidationObjects() includes a debug string for
each object which was invalidated between start and stop, and may include the
same object multiple times. (the last statement is correct, right?)

[Xianzhu, 2015-08-31 23:04:38]

https://codereview.chromium.org/1324763002/diff/1/LayoutTests/paint/invalidat...
File LayoutTests/paint/invalidation/spv2/invalidate-after-composited-scroll.html
(right):

https://codereview.chromium.org/1324763002/diff/1/LayoutTests/paint/invalidat...
LayoutTests/paint/invalidation/spv2/invalidate-after-composited-scroll.html:13:
// TODO(wangxianzhu): We should invalidate target (perhaps also the scrollbar)
only.
On 2015/08/31 22:52:19, chrishtr wrote:
> These results look wrong. The spacers etc should not invalidate, right?

They are wrong because we don't have real composited scrolling for spv2 yet. For
now we invalidate the whole scrolled subtree.

Changed this to correct result, and added a failure expectation in
TestExpectations.

https://codereview.chromium.org/1324763002/diff/1/Source/core/testing/Interna...
File Source/core/testing/Internals.idl (right):

https://codereview.chromium.org/1324763002/diff/1/Source/core/testing/Interna...
Source/core/testing/Internals.idl:247: // 
startTrackingPaintInvalidationObjects, paintInvalidationObjects,
stopTrackingPaintInvalidationObjects.
On 2015/08/31 22:52:19, chrishtr wrote:
> Add a comment that trackedPaintInvalidationObjects() includes a debug string
for
> each object which was invalidated between start and stop, and may include the
> same object multiple times. (the last statement is correct, right?)

The last statement is correct.

Done.

[chrishtr, 2015-08-31 23:07:06]

lgtm

https://codereview.chromium.org/1324763002/diff/20001/Source/core/testing/Int...
File Source/core/testing/Internals.idl (right):

https://codereview.chromium.org/1324763002/diff/20001/Source/core/testing/Int...
Source/core/testing/Internals.idl:246: // These functions both reset the tracked
paint invalidation objects. They are inteded to be used in the following order:
s/inteded/intended/

https://codereview.chromium.org/1324763002/diff/20001/Source/core/testing/Int...
Source/core/testing/Internals.idl:252: // startTrackingPaintInvalidationObjects
and stopTrackingPaintInvalidationObjects.
Add parens at the end of the funciton names to make clear it's function calls,
not variables.

[Xianzhu, 2015-08-31 23:17:57]

https://codereview.chromium.org/1324763002/diff/20001/Source/core/testing/Int...
File Source/core/testing/Internals.idl (right):

https://codereview.chromium.org/1324763002/diff/20001/Source/core/testing/Int...
Source/core/testing/Internals.idl:246: // These functions both reset the tracked
paint invalidation objects. They are inteded to be used in the following order:
On 2015/08/31 23:07:06, chrishtr wrote:
> s/inteded/intended/

Done.

https://codereview.chromium.org/1324763002/diff/20001/Source/core/testing/Int...
Source/core/testing/Internals.idl:252: // startTrackingPaintInvalidationObjects
and stopTrackingPaintInvalidationObjects.
On 2015/08/31 23:07:06, chrishtr wrote:
> Add parens at the end of the funciton names to make clear it's function calls,
> not variables.

Done.

[Xianzhu, 2015-08-31 23:18:08]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2015-08-31 23:18:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/1324763002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-08-31 23:18:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1324763002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1324763002/40001

[Xianzhu, 2015-08-31 23:22:35]

The CQ bit was unchecked by wangxianzhu@chromium.org

[Xianzhu, 2015-08-31 23:27:04]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2015-08-31 23:27:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/1324763002/#ps60001
(title: "Last patch mistakenly contains files from other branches :(")

[commit-bot: I haz the power, 2015-08-31 23:27:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1324763002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1324763002/60001

[commit-bot: I haz the power, 2015-08-31 23:41:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-31 23:41:34]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Xianzhu, 2015-09-01 16:32:07]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2015-09-01 16:32:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/1324763002/#ps80001
(title: "Yet another unrelated file mixed from another branch :(")

[commit-bot: I haz the power, 2015-09-01 16:32:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1324763002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1324763002/80001

[commit-bot: I haz the power, 2015-09-01 17:43:41]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201565