Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 1324763002: Paint invalidation tests for slimming paint v2 (Closed)

Created:
3 years, 8 months ago by Xianzhu
Modified:
3 years, 8 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-layers+watch_chromium.org, blink-reviews, Rik, Inactive, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Paint invalidation tests for slimming paint v2 Add a new type of paint invalidation test for slimming paint v2. - They are reftests, to check the correctness of painted result; - Tracks paint invalidation objects and checks them against expected list. This CL converts two paint/invalidation tests into the new style. Will convert some fast/repaint and compositing/repaint tests into this style for spv2 after this CL. The original tests are not suitable for spv2 because - it's hard to determine if a test is actually failing or needs rebaseline for spv2; - they don't cover correctness of paint results. BUG=524134 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201565

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : Last patch mistakenly contains files from other branches :( #

Patch Set 5 : Yet another unrelated file mixed from another branch :( #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -63 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
A + LayoutTests/paint/invalidation/spv2/invalidate-after-composited-scroll.html View 1 1 chunk +8 lines, -7 lines 0 comments Download
A + LayoutTests/paint/invalidation/spv2/invalidate-after-composited-scroll-expected.html View 1 chunk +3 lines, -11 lines 0 comments Download
A + LayoutTests/paint/invalidation/spv2/invalidate-after-composited-scroll-of-window.html View 1 chunk +8 lines, -7 lines 0 comments Download
A + LayoutTests/paint/invalidation/spv2/invalidate-after-composited-scroll-of-window-expected.html View 1 chunk +3 lines, -11 lines 0 comments Download
A LayoutTests/paint/invalidation/spv2/resources/paint-invalidation-test.js View 1 chunk +65 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 2 2 chunks +13 lines, -2 lines 0 comments Download
M Source/platform/graphics/GraphicsLayer.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/platform/graphics/paint/DisplayItemList.h View 4 chunks +21 lines, -1 line 0 comments Download
M Source/platform/graphics/paint/DisplayItemList.cpp View 3 chunks +12 lines, -2 lines 0 comments Download
M Source/platform/graphics/paint/DisplayItemListTest.cpp View 15 chunks +20 lines, -20 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Xianzhu
3 years, 8 months ago (2015-08-31 20:59:51 UTC) #2
chrishtr
https://codereview.chromium.org/1324763002/diff/1/LayoutTests/paint/invalidation/spv2/invalidate-after-composited-scroll.html File LayoutTests/paint/invalidation/spv2/invalidate-after-composited-scroll.html (right): https://codereview.chromium.org/1324763002/diff/1/LayoutTests/paint/invalidation/spv2/invalidate-after-composited-scroll.html#newcode13 LayoutTests/paint/invalidation/spv2/invalidate-after-composited-scroll.html:13: // TODO(wangxianzhu): We should invalidate target (perhaps also the ...
3 years, 8 months ago (2015-08-31 22:52:19 UTC) #3
Xianzhu
https://codereview.chromium.org/1324763002/diff/1/LayoutTests/paint/invalidation/spv2/invalidate-after-composited-scroll.html File LayoutTests/paint/invalidation/spv2/invalidate-after-composited-scroll.html (right): https://codereview.chromium.org/1324763002/diff/1/LayoutTests/paint/invalidation/spv2/invalidate-after-composited-scroll.html#newcode13 LayoutTests/paint/invalidation/spv2/invalidate-after-composited-scroll.html:13: // TODO(wangxianzhu): We should invalidate target (perhaps also the ...
3 years, 8 months ago (2015-08-31 23:04:38 UTC) #4
chrishtr
lgtm https://codereview.chromium.org/1324763002/diff/20001/Source/core/testing/Internals.idl File Source/core/testing/Internals.idl (right): https://codereview.chromium.org/1324763002/diff/20001/Source/core/testing/Internals.idl#newcode246 Source/core/testing/Internals.idl:246: // These functions both reset the tracked paint ...
3 years, 8 months ago (2015-08-31 23:07:06 UTC) #5
Xianzhu
https://codereview.chromium.org/1324763002/diff/20001/Source/core/testing/Internals.idl File Source/core/testing/Internals.idl (right): https://codereview.chromium.org/1324763002/diff/20001/Source/core/testing/Internals.idl#newcode246 Source/core/testing/Internals.idl:246: // These functions both reset the tracked paint invalidation ...
3 years, 8 months ago (2015-08-31 23:17:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324763002/40001
3 years, 8 months ago (2015-08-31 23:18:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324763002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324763002/60001
3 years, 8 months ago (2015-08-31 23:27:16 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/48992) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2015-08-31 23:41:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324763002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324763002/80001
3 years, 8 months ago (2015-09-01 16:32:22 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2015-09-01 17:43:41 UTC) #19
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201565

Powered by Google App Engine
This is Rietveld 408576698