Issue 13247006: Enable media stream layout test with content_shell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13247006: Enable media stream layout test with content_shell. (Closed)

Created:
7 years, 8 months ago by wjia(left Chromium)

Modified:
7 years, 8 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Enable media stream layout test with conent_shell. When using content_shell to run layout test, it's needed to use corresponding WebKit::userMediaClient and webkit_media::MediaStreamClient implemented for layout test. This patch depends on https://bugs.webkit.org/show_bug.cgi?id=113633 which export WebUserMediaClientMock. BUG=222906

Patch Set 1 #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -1 line)			Patch
M	content/public/renderer/content_renderer_client.h	View	3 chunks	+10 lines, -0 lines	1 comment	Download
M	content/public/renderer/content_renderer_client.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	2 chunks	+14 lines, -1 line	1 comment	Download
M	content/shell/shell_content_renderer_client.h	View	3 chunks	+9 lines, -0 lines	0 comments	Download
M	content/shell/shell_content_renderer_client.cc	View	2 chunks	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

7 years, 8 months ago (2013-04-01 15:51:45 UTC) #2

lgtm

https://codereview.chromium.org/13247006/diff/1/content/public/renderer/conte...
File content/public/renderer/content_renderer_client.h (right):

https://codereview.chromium.org/13247006/diff/1/content/public/renderer/conte...
content/public/renderer/content_renderer_client.h:140: // returns NULL the
content layer will create the userMediaClient.
userMediaClient -> WebUserMediaClient

https://codereview.chromium.org/13247006/diff/1/content/renderer/render_view_...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/13247006/diff/1/content/renderer/render_view_...
content/renderer/render_view_impl.cc:2681: // For layout test with
content_shell.
nit: don't mention what an embedder might use this for.

Expand Messages | Collapse Messages