Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/src/checker/resolver.dart

Issue 1324693004: Fixes for Angular (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Reformat Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/js.js ('k') | tool/input_sdk/lib/js/dart2js/js_dart2js.dart » ('j') | tool/input_sdk/lib/js/dart2js/js_dart2js.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/checker/resolver.dart
diff --git a/lib/src/checker/resolver.dart b/lib/src/checker/resolver.dart
index 46533575611fb21830b266f18e238a7e4da041bd..29886abaa49b15610d84aad8ca283c6942417058 100644
--- a/lib/src/checker/resolver.dart
+++ b/lib/src/checker/resolver.dart
@@ -662,8 +662,9 @@ class RestrictedStaticTypeAnalyzer extends StaticTypeAnalyzer {
if (e?.name == generic[1]) {
if ((generic[0] is String &&
element?.library.source.uri.toString() == generic[0]) ||
- (targetType == generic[0] ||
- targetType != null && targetType.isSubtypeOf(generic[0]))) {
+ (generic[0] is DartType &&
vsm 2015/09/02 19:14:32 We were accidentally calling isSubtypeOf with a St
Leaf 2015/09/02 20:34:03 youch.
+ targetType != null &&
+ targetType.isSubtypeOf(generic[0]))) {
if (arguments.length == generic[2]) {
return Function.apply(
generic[3], arguments.map((arg) => arg.staticType).toList());
« no previous file with comments | « lib/runtime/dart/js.js ('k') | tool/input_sdk/lib/js/dart2js/js_dart2js.dart » ('j') | tool/input_sdk/lib/js/dart2js/js_dart2js.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698