Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1324693004: Fixes for Angular (Closed)

Created:
5 years, 3 months ago by vsm
Modified:
5 years, 3 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Reformat #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M lib/runtime/dart/js.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/checker/resolver.dart View 1 chunk +3 lines, -2 lines 2 comments Download
M tool/input_sdk/lib/js/dart2js/js_dart2js.dart View 1 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 4 (1 generated)
vsm
https://codereview.chromium.org/1324693004/diff/20001/lib/src/checker/resolver.dart File lib/src/checker/resolver.dart (right): https://codereview.chromium.org/1324693004/diff/20001/lib/src/checker/resolver.dart#newcode665 lib/src/checker/resolver.dart:665: (generic[0] is DartType && We were accidentally calling isSubtypeOf ...
5 years, 3 months ago (2015-09-02 19:14:33 UTC) #2
Leaf
lgtm https://codereview.chromium.org/1324693004/diff/20001/lib/src/checker/resolver.dart File lib/src/checker/resolver.dart (right): https://codereview.chromium.org/1324693004/diff/20001/lib/src/checker/resolver.dart#newcode665 lib/src/checker/resolver.dart:665: (generic[0] is DartType && On 2015/09/02 19:14:32, vsm ...
5 years, 3 months ago (2015-09-02 20:34:03 UTC) #3
vsm
5 years, 3 months ago (2015-09-02 20:40:10 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
a31b50342a556aaf4e8f6cf33429c93a201d108d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698