Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1324673002: Use #if DCHECK_IS_ON() in base/threading/thread_checker.h (Closed)

Created:
5 years, 3 months ago by Olli Raula
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use #if DCHECK_IS_ON() in base/threading/thread_checker.h Use #if DCHECK_IS_ON() instead of (!defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)) in base/threading/thread_checker.h because it is same thing and more succinct and centralized. Committed: https://crrev.com/3e81715e6d3a4324362635aea46ce1f1a163cca1 Cr-Commit-Position: refs/heads/master@{#346574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M base/threading/thread_checker.h View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Olli Raula
Could you review?
5 years, 3 months ago (2015-08-31 10:36:07 UTC) #2
Lei Zhang
Can you change the subject line and the first line in the CL description to ...
5 years, 3 months ago (2015-08-31 21:40:04 UTC) #3
Lei Zhang
Otherwise lgtm
5 years, 3 months ago (2015-08-31 21:40:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324673002/1
5 years, 3 months ago (2015-09-01 05:32:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 05:37:01 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 05:37:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e81715e6d3a4324362635aea46ce1f1a163cca1
Cr-Commit-Position: refs/heads/master@{#346574}

Powered by Google App Engine
This is Rietveld 408576698