Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3443)

Unified Diff: build/android/pylib/device/adb_wrapper_test.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/device/adb_wrapper.py ('k') | build/android/pylib/flag_changer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/device/adb_wrapper_test.py
diff --git a/build/android/pylib/device/adb_wrapper_test.py b/build/android/pylib/device/adb_wrapper_test.py
index 1e533c4770e934c14eb4971996e66eac8cabd197..52bedb498066fdb56a57d69c8b07c79763b476a4 100644
--- a/build/android/pylib/device/adb_wrapper_test.py
+++ b/build/android/pylib/device/adb_wrapper_test.py
@@ -5,12 +5,11 @@
"""Tests for the AdbWrapper class."""
import os
-import socket
import tempfile
import time
import unittest
-import adb_wrapper
+from pylib.device import adb_wrapper
class TestAdbWrapper(unittest.TestCase):
@@ -21,7 +20,8 @@ class TestAdbWrapper(unittest.TestCase):
self._adb = devices[0]
self._adb.WaitForDevice()
- def _MakeTempFile(self, contents):
+ @staticmethod
+ def _MakeTempFile(contents):
"""Make a temporary file with the given contents.
Args:
@@ -32,7 +32,7 @@ class TestAdbWrapper(unittest.TestCase):
"""
fi, path = tempfile.mkstemp()
with os.fdopen(fi, 'wb') as f:
- f.write('foo')
+ f.write(contents)
return path
def testShell(self):
« no previous file with comments | « build/android/pylib/device/adb_wrapper.py ('k') | build/android/pylib/flag_changer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698