Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3039)

Unified Diff: build/android/gyp/generate_v14_compatible_resources.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/gyp/gcc_preprocess.py ('k') | build/android/gyp/get_device_configuration.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/generate_v14_compatible_resources.py
diff --git a/build/android/gyp/generate_v14_compatible_resources.py b/build/android/gyp/generate_v14_compatible_resources.py
index a321de0308001a11c95b9967be6491d6ce57b9fb..8f9c7df5da2980b53c65226408429496bbac7255 100755
--- a/build/android/gyp/generate_v14_compatible_resources.py
+++ b/build/android/gyp/generate_v14_compatible_resources.py
@@ -26,7 +26,7 @@ import shutil
import sys
import xml.dom.minidom as minidom
-from util import build_utils
+from util import build_utils # pylint: disable=F0401
# Note that we are assuming 'android:' is an alias of
# the namespace 'http://schemas.android.com/apk/res/android'.
@@ -51,7 +51,7 @@ ATTRIBUTES_TO_MAP = {'paddingStart' : 'paddingLeft',
ATTRIBUTES_TO_MAP = dict(['android:' + k, 'android:' + v] for k, v
in ATTRIBUTES_TO_MAP.iteritems())
-ATTRIBUTES_TO_MAP_REVERSED = dict([v,k] for k, v
+ATTRIBUTES_TO_MAP_REVERSED = dict([v, k] for k, v
in ATTRIBUTES_TO_MAP.iteritems())
@@ -281,7 +281,7 @@ def ParseArgs():
return options
-def main(argv):
+def main():
options = ParseArgs()
build_utils.DeleteDirectory(options.res_v14_compatibility_dir)
@@ -342,5 +342,5 @@ def main(argv):
build_utils.Touch(options.stamp)
if __name__ == '__main__':
- sys.exit(main(sys.argv))
+ sys.exit(main())
« no previous file with comments | « build/android/gyp/gcc_preprocess.py ('k') | build/android/gyp/get_device_configuration.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698