build/android/gyp/finalize_apk.py - Issue 132463007: Enable presubmit pylint in build/android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/finalize_apk.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/gyp/finalize_apk.py

diff --git a/build/android/gyp/finalize_apk.py b/build/android/gyp/finalize_apk.py

index 6e4685ce6d1f610c5a4a6fbb3cee386eb1782b41..770ef1766de82a81ab5b6e6804c01c8db8dd14a5 100755

--- a/build/android/gyp/finalize_apk.py

+++ b/build/android/gyp/finalize_apk.py

@@ -13,7 +13,7 @@ import shutil

import sys

import tempfile

-from util import build_utils

+from util import build_utils # pylint: disable=F0401

def SignApk(keystore_path, unsigned_path, signed_path):

shutil.copy(unsigned_path, signed_path)

@@ -39,7 +39,7 @@ def AlignApk(android_sdk_root, unaligned_path, final_path):

build_utils.CheckOutput(align_cmd)

-def main(argv):

+def main():

parser = optparse.OptionParser()

parser.add_option('--android-sdk-root', help='Android sdk root directory.')

@@ -64,6 +64,6 @@ def main(argv):

if __name__ == '__main__':

- sys.exit(main(sys.argv))

+ sys.exit(main())

« no previous file with comments | « build/android/gyp/emma_instr.py ('k') | build/android/gyp/gcc_preprocess.py » ('j') | no next file with comments »