Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2441)

Unified Diff: build/android/PRESUBMIT.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/adb_logcat_monitor.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/PRESUBMIT.py
diff --git a/build/android/PRESUBMIT.py b/build/android/PRESUBMIT.py
index d8e5ae34bb4e1d4a53f8e67b01c262a653f369af..85a1eda20d83b42f7c2bdf734a40f4616db06272 100644
--- a/build/android/PRESUBMIT.py
+++ b/build/android/PRESUBMIT.py
@@ -35,10 +35,13 @@ def CommonChecks(input_api, output_api):
"""Returns a path relative to presubmit directory."""
return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs)
+ # F0401 is issued when pylint can't import a module, but it doesn't seem to
+ # work correctly on our scripts.
output.extend(input_api.canned_checks.RunPylint(
input_api,
output_api,
- white_list=[r'PRESUBMIT\.py$', r'buildbot/.*\.py$'],
+ white_list=[r'.*\.py$'],
+ black_list=[r'pylib/android_commands\.py$'],
extra_paths_list=[
J(), J('..', '..', 'third_party', 'android_testrunner'),
J('buildbot')]))
« no previous file with comments | « no previous file | build/android/adb_logcat_monitor.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698