Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1280)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/android/pylib/utils/flakiness_dashboard_results_uploader.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move disables into modules. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/android/PRESUBMIT.py ('K') | « build/android/pylib/utils/findbugs.py ('k') | build/android/pylib/utils/report_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/utils/flakiness_dashboard_results_uploader.py
diff --git a/build/android/pylib/utils/flakiness_dashboard_results_uploader.py b/build/android/pylib/utils/flakiness_dashboard_results_uploader.py
index e74145f79535354af7c0cdb67677cfdda8e4d789..5f847daa35c99250834a6eb3b1538bc15adcbb5b 100644
--- a/build/android/pylib/utils/flakiness_dashboard_results_uploader.py
+++ b/build/android/pylib/utils/flakiness_dashboard_results_uploader.py
@@ -3,11 +3,11 @@
# found in the LICENSE file.
"""Uploads the results to the flakiness dashboard server."""
+# pylint: disable=E1002,R0201
import logging
import os
import shutil
-import subprocess
import sys
import tempfile
import xml
@@ -188,7 +188,7 @@ class ResultsUploader(object):
results_generator.generate_times_ms_file()
results_generator.upload_json_files(json_files)
except Exception as e:
- logging.error("Uploading results to test server failed: %s." % e);
+ logging.error("Uploading results to test server failed: %s." % e)
finally:
shutil.rmtree(tmp_folder)
« build/android/PRESUBMIT.py ('K') | « build/android/pylib/utils/findbugs.py ('k') | build/android/pylib/utils/report_results.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698