build/android/PRESUBMIT.py - Issue 132463007: Enable presubmit pylint in build/android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/PRESUBMIT.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move disables into modules. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/PRESUBMIT.py

diff --git a/build/android/PRESUBMIT.py b/build/android/PRESUBMIT.py

index d8e5ae34bb4e1d4a53f8e67b01c262a653f369af..8561cbd50fb8ccd109d54f126fb0583de7d27ef4 100644

--- a/build/android/PRESUBMIT.py

+++ b/build/android/PRESUBMIT.py

@@ -38,7 +38,9 @@ def CommonChecks(input_api, output_api):

output.extend(input_api.canned_checks.RunPylint(

input_api,

output_api,

- white_list=[r'PRESUBMIT\.py$', r'buildbot/.*\.py$'],

+ white_list=[r'.*\.py$'],

+ black_list=[r'pylib/android_commands\.py$'],

frankf 2014/02/03 21:49:30 could you also do this in the code?

jbudorick 2014/02/03 21:53:52 Yes, but ignoring files is kind of the point of th

+ disabled_warnings=['F0401'],

frankf 2014/02/03 21:49:30 why disable this?

jbudorick 2014/02/03 21:53:52 It doesn't seem to work correctly.

extra_paths_list=[

J(), J('..', '..', 'third_party', 'android_testrunner'),

J('buildbot')]))

« no previous file with comments | « no previous file | build/android/adb_logcat_monitor.py » ('j') | no next file with comments »