Issue 132453009: Binary operation deoptimization fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132453009: Binary operation deoptimization fix. (Closed)

Created:
6 years, 10 months ago by Jarin

Modified:
6 years, 10 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Binary operation deoptimization fix. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19132

Patch Set 2 : Minor tweaks + added test #

Total comments: 2

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -34 lines)			Patch
M	src/hydrogen.h	View	1	1 chunk	+7 lines, -1 line	1 comment	Download
M	src/hydrogen.cc	View	1	4 chunks	+17 lines, -6 lines	1 comment	Download
A +	test/mjsunit/regress/binop-in-effect-context-deopt.js	View	1	1 chunk	+36 lines, -27 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with nits. https://codereview.chromium.org/132453009/diff/30001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/132453009/diff/30001/src/hydrogen.cc#newcode9463 src/hydrogen.cc:9463: ast_context()->IsEffect() nit: preferred formatting: ast_context()->IsEffect() ? ...

6 years, 10 months ago (2014-02-06 08:33:40 UTC) #2

Jarin

6 years, 10 months ago (2014-02-06 09:37:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r19132 (presubmit successful).

Expand Messages | Collapse Messages

Issue 132453009: Binary operation deoptimization fix. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Minor tweaks + added test #

Messages