Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: src/hydrogen.h

Issue 132453009: Binary operation deoptimization fix. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Minor tweaks + added test Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | src/hydrogen.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2400 matching lines...) Expand 10 before | Expand all | Expand 10 after
2411 HValue* right, 2411 HValue* right,
2412 Type* left_type, 2412 Type* left_type,
2413 Type* right_type, 2413 Type* right_type,
2414 Type* combined_type, 2414 Type* combined_type,
2415 int left_position, 2415 int left_position,
2416 int right_position, 2416 int right_position,
2417 BailoutId bailout_id); 2417 BailoutId bailout_id);
2418 2418
2419 HInstruction* BuildStringCharCodeAt(HValue* string, 2419 HInstruction* BuildStringCharCodeAt(HValue* string,
2420 HValue* index); 2420 HValue* index);
2421
2422 enum PushBeforeSimulateBehavior {
2423 PUSH_BEFORE_SIMULATE,
2424 NO_PUSH_BEFORE_SIMULATE
2425 };
2421 HValue* BuildBinaryOperation(BinaryOperation* expr, 2426 HValue* BuildBinaryOperation(BinaryOperation* expr,
2422 HValue* left, 2427 HValue* left,
2423 HValue* right); 2428 HValue* right,
2429 PushBeforeSimulateBehavior pushSimResult);
Jakob Kummerow 2014/02/06 08:33:41 nit: unix_hacker_style for variable names (remembe
2424 HInstruction* BuildIncrement(bool returns_original_input, 2430 HInstruction* BuildIncrement(bool returns_original_input,
2425 CountOperation* expr); 2431 CountOperation* expr);
2426 HInstruction* BuildLoadKeyedGeneric(HValue* object, 2432 HInstruction* BuildLoadKeyedGeneric(HValue* object,
2427 HValue* key); 2433 HValue* key);
2428 2434
2429 HInstruction* TryBuildConsolidatedElementLoad(HValue* object, 2435 HInstruction* TryBuildConsolidatedElementLoad(HValue* object,
2430 HValue* key, 2436 HValue* key,
2431 HValue* val, 2437 HValue* val,
2432 SmallMapList* maps); 2438 SmallMapList* maps);
2433 2439
(...skipping 290 matching lines...) Expand 10 before | Expand all | Expand 10 after
2724 } 2730 }
2725 2731
2726 private: 2732 private:
2727 HGraphBuilder* builder_; 2733 HGraphBuilder* builder_;
2728 }; 2734 };
2729 2735
2730 2736
2731 } } // namespace v8::internal 2737 } } // namespace v8::internal
2732 2738
2733 #endif // V8_HYDROGEN_H_ 2739 #endif // V8_HYDROGEN_H_
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | src/hydrogen.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698