Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Unified Diff: Source/core/editing/VisiblePosition.h

Issue 1324463002: Introduce lineDirectionPointForBlockDirectionNavigationOf() for VisiblePosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-28T17:32:46 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/FrameSelection.cpp ('k') | Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/VisiblePosition.h
diff --git a/Source/core/editing/VisiblePosition.h b/Source/core/editing/VisiblePosition.h
index 405202bf5a05e75eed0d389c8184713dc6f8fe14..651d8762b6d959bdee7a19dd09ae015f0e05fac1 100644
--- a/Source/core/editing/VisiblePosition.h
+++ b/Source/core/editing/VisiblePosition.h
@@ -115,9 +115,6 @@ public:
LayoutRect localCaretRect(LayoutObject*&) const;
// Bounds of (possibly transformed) caret in absolute coords
IntRect absoluteCaretBounds() const;
- // Abs x/y position of the caret ignoring transforms.
- // FIXME: navigation with transforms should be smarter.
- int lineDirectionPointForBlockDirectionNavigation() const;
DECLARE_TRACE();
@@ -138,6 +135,13 @@ private:
TextAffinity m_affinity;
};
+// Abs x/y position of the caret ignoring transforms.
+// TODO(yosin) navigation with transforms should be smarter.
+// TODO(yosin) We should move a glboal funciton
+// |lineDirectionPointForBlockDirectionNavigationOf()| to "FrameSelection.h"
+// as static function.
+int lineDirectionPointForBlockDirectionNavigationOf(const VisiblePosition&);
+
EphemeralRange makeRange(const VisiblePosition&, const VisiblePosition&);
CORE_EXPORT Position canonicalPositionOf(const Position&);
« no previous file with comments | « Source/core/editing/FrameSelection.cpp ('k') | Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698