Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Unified Diff: Source/core/editing/VisiblePosition.cpp

Issue 1324463002: Introduce lineDirectionPointForBlockDirectionNavigationOf() for VisiblePosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-28T17:32:46 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/VisiblePosition.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/VisiblePosition.cpp
diff --git a/Source/core/editing/VisiblePosition.cpp b/Source/core/editing/VisiblePosition.cpp
index ac504cf8c72116edf85ff6ae074548e2d485c52d..89c336660763f873112b96d395da05671e91acd2 100644
--- a/Source/core/editing/VisiblePosition.cpp
+++ b/Source/core/editing/VisiblePosition.cpp
@@ -697,13 +697,16 @@ IntRect VisiblePosition::absoluteCaretBounds() const
return layoutObject->localToAbsoluteQuad(FloatRect(localRect)).enclosingBoundingBox();
}
-int VisiblePosition::lineDirectionPointForBlockDirectionNavigation() const
+// TODO(yosin) We should move a global function
+// |lineDirectionPointForBlockDirectionNavigationOf()| to "FrameSelection.h"
+// as static function.
+int lineDirectionPointForBlockDirectionNavigationOf(const VisiblePosition& visiblePosition)
{
- if (isNull())
+ if (visiblePosition.isNull())
return 0;
LayoutObject* layoutObject;
- LayoutRect localRect = localCaretRect(layoutObject);
+ LayoutRect localRect = visiblePosition.localCaretRect(layoutObject);
if (localRect.isEmpty() || !layoutObject)
return 0;
« no previous file with comments | « Source/core/editing/VisiblePosition.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698