Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1324463002: Introduce lineDirectionPointForBlockDirectionNavigationOf() for VisiblePosition (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce lineDirectionPointForBlockDirectionNavigationOf() for VisiblePosition This patch introduces |lineDirectionPointForBlockDirectionNavigationOf()| function for |VisiblePosition| as replacement of |VisiblePosition::lineDirectionPointForBlockDirectionNavigation()| to simplify |VisiblePosition| class for ease of templataizing |VisiblePosition| class to introduce composed tree version of |VisiblePosition|, since an implementation of |VisiblePosition::lineDirectionPointForBlockDirectionNavigation()| can be implemented with public member functions of |VisiblePosition| class. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; No behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201387

Patch Set 1 : 2015-08-28T17:32:46 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisiblePosition.h View 2 chunks +7 lines, -3 lines 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-08-28 08:59:53 UTC) #2
hajimehoshi
lgtm
5 years, 3 months ago (2015-08-28 09:10:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324463002/1
5 years, 3 months ago (2015-08-28 09:11:05 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 09:44:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201387

Powered by Google App Engine
This is Rietveld 408576698