Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1324453006: jni: Remove no-longer-needed calls to NewLocalRef. (Closed)

Created:
5 years, 3 months ago by Torne
Modified:
5 years, 3 months ago
Reviewers:
Yaron
CC:
chromium-reviews, darin-cc_chromium.org, klundberg+watch_chromium.org, jam, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

jni: Remove no-longer-needed calls to NewLocalRef. We no longer need to explicitly create new local references to put into ScopedJavaLocalRef to avoid JNI warnings; we can just pass JavaParamRefs around safely now. Remove temporary fixes added in https://codereview.chromium.org/1278823006 and do that instead. BUG=506850 Committed: https://crrev.com/9d46f6be2e866a727a83da5096cca87ee722532d Cr-Commit-Position: refs/heads/master@{#347396}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M content/app/android/child_process_service.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M content/app/android/content_main.cc View 1 chunk +1 line, -3 lines 0 comments Download
M testing/android/native_test/native_test_launcher.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Torne
5 years, 3 months ago (2015-09-04 13:05:24 UTC) #2
Yaron
lgtm
5 years, 3 months ago (2015-09-04 13:32:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324453006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324453006/1
5 years, 3 months ago (2015-09-04 13:34:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 13:57:20 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 13:58:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d46f6be2e866a727a83da5096cca87ee722532d
Cr-Commit-Position: refs/heads/master@{#347396}

Powered by Google App Engine
This is Rietveld 408576698