Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1278823006: Fix a few CHECK_JNI failures. (Closed)

Created:
5 years, 4 months ago by Yaron
Modified:
5 years, 4 months ago
Reviewers:
Torne
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a few CHECK_JNI failures. Passed in jobjects should not be released. Using ScopedLocalJavaRef(env, jobject) with a parameter passed in from JNI adopts the jojbect from the param and incorrectly tries to release it. Committed: https://crrev.com/87fe94b76553a4fa4415fb9b37476e56c1a0bbcc Cr-Commit-Position: refs/heads/master@{#342609}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M content/app/android/child_process_service.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M content/app/android/content_main.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/app/ChildProcessService.java View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Yaron
I know you were talking about fixing these more systemically but this is a smaller ...
5 years, 4 months ago (2015-08-07 18:39:38 UTC) #2
Torne
This will do for now until we fix this better. It's not ideal to just ...
5 years, 4 months ago (2015-08-10 10:53:06 UTC) #3
Yaron
On 2015/08/10 10:53:06, Torne wrote: > This will do for now until we fix this ...
5 years, 4 months ago (2015-08-10 12:22:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278823006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278823006/1
5 years, 4 months ago (2015-08-10 12:22:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-10 13:27:16 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 13:28:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87fe94b76553a4fa4415fb9b37476e56c1a0bbcc
Cr-Commit-Position: refs/heads/master@{#342609}

Powered by Google App Engine
This is Rietveld 408576698