Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1324383002: [Sync] Add initial merging logic for typed urls syncable service (Closed)

Created:
5 years, 3 months ago by Gang Wu
Modified:
5 years, 3 months ago
Reviewers:
Nicolas Zea, rkaplow, sky
CC:
chromium-reviews, Alexei Svitkine (slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This implements the equivalent of AssociateModels in the model associator. The equivalent unit tests (and more!) have been added as well. Original patch by zea@chromium.org at https://codereview.chromium.org/14813023/ BUG=77819 Committed: https://crrev.com/be1fbefb27898d7a894b499ba89d00e76d45b1a8 Cr-Commit-Position: refs/heads/master@{#349690}

Patch Set 1 : from patch 14813023, and fix compiler error. #

Patch Set 2 : add new UMA histogram, and fix tests issue. #

Total comments: 2

Patch Set 3 : fix comment format #

Patch Set 4 : add zea@chromium.org into OWNERS #

Total comments: 1

Patch Set 5 : use per-file in OWNERS file #

Total comments: 1

Patch Set 6 : histogram.h -> histogram_macro.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1216 lines, -260 lines) Patch
M components/history/OWNERS View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/history/core/browser/typed_url_syncable_service.h View 1 9 chunks +75 lines, -28 lines 0 comments Download
M components/history/core/browser/typed_url_syncable_service.cc View 1 2 3 4 5 13 chunks +528 lines, -23 lines 0 comments Download
M components/history/core/browser/typed_url_syncable_service_unittest.cc View 1 2 17 chunks +603 lines, -209 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (8 generated)
Gang Wu
Please take a look.
5 years, 3 months ago (2015-09-11 18:08:32 UTC) #2
Gang Wu
Add new histogram "Sync.TypedUrlMergeAndStartSyncingErrors" which is pretty much same as "Sync.TypedUrlModelAssociationErrors", but for new service.
5 years, 3 months ago (2015-09-11 18:19:14 UTC) #4
Nicolas Zea
It would be useful to have one patchset be my original patch, and a followup ...
5 years, 3 months ago (2015-09-11 20:51:34 UTC) #5
Gang Wu
On 2015/09/11 20:51:34, Nicolas Zea wrote: > It would be useful to have one patchset ...
5 years, 3 months ago (2015-09-11 22:01:38 UTC) #8
Nicolas Zea
This LGTM, with the caveat that I'm pretty sure we'll need followup patches to bring ...
5 years, 3 months ago (2015-09-15 19:44:08 UTC) #9
Gang Wu
please take a look. https://codereview.chromium.org/1324383002/diff/60001/components/history/core/browser/typed_url_syncable_service_unittest.cc File components/history/core/browser/typed_url_syncable_service_unittest.cc (right): https://codereview.chromium.org/1324383002/diff/60001/components/history/core/browser/typed_url_syncable_service_unittest.cc#newcode356 components/history/core/browser/typed_url_syncable_service_unittest.cc:356: // that On 2015/09/15 19:44:08, ...
5 years, 3 months ago (2015-09-16 06:08:23 UTC) #11
Gang Wu
please take a look.
5 years, 3 months ago (2015-09-16 06:08:51 UTC) #12
Gang Wu
please take a look.
5 years, 3 months ago (2015-09-16 06:09:03 UTC) #13
sky
Sorry, I'm not familiar with this code at all. How is the original author and ...
5 years, 3 months ago (2015-09-16 19:52:15 UTC) #14
Gang Wu
On 2015/09/16 19:52:15, sky wrote: > Sorry, I'm not familiar with this code at all. ...
5 years, 3 months ago (2015-09-16 20:04:24 UTC) #15
Nicolas Zea
On 2015/09/16 20:04:24, Gang Wu wrote: > On 2015/09/16 19:52:15, sky wrote: > > Sorry, ...
5 years, 3 months ago (2015-09-16 20:07:53 UTC) #16
sky
Can you update the OWNERs file, adding zea to the appropriate set of files?
5 years, 3 months ago (2015-09-16 20:13:54 UTC) #17
Gang Wu
OWNERS file updated!
5 years, 3 months ago (2015-09-16 20:43:57 UTC) #18
Nicolas Zea
https://codereview.chromium.org/1324383002/diff/100001/components/history/OWNERS File components/history/OWNERS (right): https://codereview.chromium.org/1324383002/diff/100001/components/history/OWNERS#newcode3 components/history/OWNERS:3: zea@chromium.org Could you make this be a per-file rule ...
5 years, 3 months ago (2015-09-16 20:45:00 UTC) #19
Gang Wu
updated OWNERS by using per-file.
5 years, 3 months ago (2015-09-16 23:20:24 UTC) #20
sky
LGTM for owners change
5 years, 3 months ago (2015-09-16 23:50:49 UTC) #21
Alexei Svitkine (slow)
+rkaplow, Rob - can you help review the metrics in this CL? Thanks
5 years, 3 months ago (2015-09-17 16:45:18 UTC) #23
rkaplow
lgtm histograms lgtm https://codereview.chromium.org/1324383002/diff/120001/components/history/core/browser/typed_url_syncable_service.cc File components/history/core/browser/typed_url_syncable_service.cc (right): https://codereview.chromium.org/1324383002/diff/120001/components/history/core/browser/typed_url_syncable_service.cc#newcode9 components/history/core/browser/typed_url_syncable_service.cc:9: #include "base/metrics/histogram.h" histogram_macros.h
5 years, 3 months ago (2015-09-17 20:18:47 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324383002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324383002/140001
5 years, 3 months ago (2015-09-18 16:18:00 UTC) #27
commit-bot: I haz the power
Committed patchset #6 (id:140001)
5 years, 3 months ago (2015-09-18 16:23:14 UTC) #28
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 16:23:44 UTC) #29
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/be1fbefb27898d7a894b499ba89d00e76d45b1a8
Cr-Commit-Position: refs/heads/master@{#349690}

Powered by Google App Engine
This is Rietveld 408576698