Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13243003: Move MessageLoop to base namespace. (Closed)

Created:
7 years, 8 months ago by brettw
Modified:
7 years, 8 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, dhollowa+watch_chromium.org, amit, ahutter, browser-components-watch_chromium.org, piman+watch_chromium.org, Raman Kakilate, Ilya Sherman, sergeyu+watch_chromium.org, dcaiafa+watch_chromium.org, cbentzel+watch_chromium.org, vsevik, benquan, stevenjb+watch_chromium.org, jam, dbeam+watch-autofill_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright (departed), chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, android-webview-reviews_chromium.org, tim (not reviewing), Dane Wallinga, jonathan.backer, wez+watch_chromium.org, Raghu Simha, sanjeevr, simonmorris+watch_chromium.org, feature-media-reviews_chromium.org, rmsousa+watch_chromium.org, oshima+watch_chromium.org, Albert Bodenhamer, haitaol1, alexeypa+watch_chromium.org, jochen+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, akalin, Ian Vollick, tfarina, yurys, garykac+watch_chromium.org, Aaron Boodman, lambroslambrou+watch_chromium.org, robertshield, davemoore+watch_chromium.org, dyu1, grt+watch_chromium.org, estade+watch_chromium.org, cc-bugs_chromium.org, James Su, pfeldman
Visibility:
Public.

Description

Move MessageLoop to base namespace. This adds a "using" to the header to avoid having to update everything at once. However, all forward declares and the locations that use the forward declares need to be updated (since they don't see the using in message_loop.h). BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191566

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : ui #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+465 lines, -382 lines) Patch
M android_webview/browser/aw_browser_main_parts.h View 2 chunks +3 lines, -1 line 0 comments Download
M base/message_loop.h View 2 chunks +9 lines, -1 line 0 comments Download
M base/message_loop.cc View 23 chunks +43 lines, -43 lines 0 comments Download
M base/message_loop_unittest.cc View 61 chunks +170 lines, -172 lines 0 comments Download
M base/test/sequenced_worker_pool_owner.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/timer.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/test/cc_test_suite.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/user_image_loader.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_adb_bridge.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_error_reporter.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_prompt.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_uninstall_dialog.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/google/google_update_win.h View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/importer/firefox_importer_unittest_utils.h View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/printing/print_job_worker_owner.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/printing/printer_query.h View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/password_change_processor.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/password_model_associator.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.h View 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_registrar.h View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_change_processor.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/ui_model_worker.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/sync/one_click_signin_bubble_view.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/thumbnail_source.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/thumbnail_source.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/theme_source.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_data_request_manager.h View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/webdata/web_data_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/mac/mock_launchd.h View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome_frame/urlmon_url_request.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/browser_main_loop.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/device_orientation/provider_impl.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/histogram_synchronizer.h View 4 chunks +7 lines, -4 lines 0 comments Download
M content/common/child_histogram_message_filter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/child_thread.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/browser_thread.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/public/browser/histogram_fetcher.h View 2 chunks +7 lines, -3 lines 0 comments Download
M content/public/browser/url_data_source.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/browser/url_data_source.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/content_renderer_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/renderer/render_thread.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/test/test_browser_thread.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/devtools/devtools_agent_filter.h View 2 chunks +5 lines, -2 lines 0 comments Download
M content/shell/shell_url_request_context_getter.h View 3 chunks +6 lines, -4 lines 0 comments Download
M extensions/browser/file_reader.h View 2 chunks +3 lines, -1 line 0 comments Download
M ipc/ipc_test_base.h View 2 chunks +3 lines, -1 line 0 comments Download
M jingle/glue/channel_socket_adapter.h View 2 chunks +3 lines, -1 line 0 comments Download
M jingle/glue/fake_socket_factory.h View 2 chunks +3 lines, -1 line 0 comments Download
M media/audio/audio_device_thread.h View 2 chunks +3 lines, -1 line 0 comments Download
M media/audio/audio_manager.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/audio/audio_output_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/audio/audio_output_dispatcher.h View 2 chunks +3 lines, -1 line 0 comments Download
M media/audio/audio_output_dispatcher_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/audio/linux/alsa_output.h View 2 chunks +3 lines, -1 line 0 comments Download
M media/base/pipeline.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/test_helpers.h View 2 chunks +3 lines, -1 line 0 comments Download
M media/filters/gpu_video_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/player_x11/gl_video_renderer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/tools/player_x11/x11_video_renderer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/cookies/cookie_store_test_callbacks.h View 2 chunks +4 lines, -5 lines 0 comments Download
M net/proxy/mock_proxy_resolver.h View 3 chunks +4 lines, -2 lines 0 comments Download
M net/proxy/proxy_config_service_linux.h View 4 chunks +4 lines, -5 lines 0 comments Download
M net/proxy/proxy_service.h View 4 chunks +4 lines, -4 lines 0 comments Download
M net/test/net_test_suite.h View 2 chunks +3 lines, -1 line 0 comments Download
M printing/printed_document.h View 2 chunks +2 lines, -3 lines 0 comments Download
M remoting/base/auto_thread_task_runner.h View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/base/plugin_thread_task_runner.h View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/host/register_support_host_request.h View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/protocol/connection_tester.h View 3 chunks +4 lines, -2 lines 0 comments Download
M remoting/protocol/fake_session.h View 4 chunks +5 lines, -3 lines 0 comments Download
M sync/engine/sync_scheduler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sync/engine/sync_scheduler_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/engine/passive_model_worker.h View 3 chunks +4 lines, -2 lines 0 comments Download
M sync/internal_api/public/http_bridge.h View 2 chunks +5 lines, -2 lines 0 comments Download
M ui/aura/test/aura_test_base.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/aura_test_helper.h View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M ui/aura/test/aura_test_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/test/test_suite.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/test/views_test_base.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/test/webview_test_helper.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/test/webview_test_helper.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webkitplatformsupport_impl.h View 2 chunks +3 lines, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_instance.h View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
brettw
TBR=sky@chromium.org cc: TBR=enne@chromium.org extensions: TBR=finnur@chromium.org jingle: TBR=ajwong@chromium.org media: TBR=fischmen@chromium.org net: TBR=mattm@chromium.org printing: TBR=thestig@chromium.org remoting: TBR=wez@chromium.org ...
7 years, 8 months ago (2013-03-30 04:56:49 UTC) #1
Lei Zhang
printing lgtm
7 years, 8 months ago (2013-03-30 06:42:44 UTC) #2
Ami GONE FROM CHROMIUM
media/ LGTM
7 years, 8 months ago (2013-03-30 18:43:27 UTC) #3
Nicolas Zea
sync LGTM
7 years, 8 months ago (2013-03-30 19:07:47 UTC) #4
Wez
remoting/ LGTM
7 years, 8 months ago (2013-03-30 21:36:50 UTC) #5
Finnur
extensions/ (amd google_update_win.h) LGTM
7 years, 8 months ago (2013-03-30 22:02:50 UTC) #6
brettw
Committed patchset #4 manually as r191566.
7 years, 8 months ago (2013-03-31 02:29:33 UTC) #7
awong
LGTM
7 years, 8 months ago (2013-04-01 19:52:58 UTC) #8
enne (OOO)
cc lgtm
7 years, 8 months ago (2013-04-01 19:54:59 UTC) #9
mattm
7 years, 8 months ago (2013-04-01 20:24:40 UTC) #10
Message was sent while issue was closed. 
net lgtm

Powered by Google App Engine
This is Rietveld 408576698