Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1324293003: Revert of Refactor connection_security into SecurityStateModel (Closed)

Created:
5 years, 3 months ago by estark
Modified:
5 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, creis+watch_chromium.org, tfarina, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, James Su, felt
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor connection_security into SecurityStateModel (patchset #17 id:360001 of https://codereview.chromium.org/1314843007/ ) Reason for revert: We need to call SecurityStateChanged() in a few more places to avoid a crash and some UI bugs. See bugs 529664 and 529872. Original issue's description: > Refactor connection_security into SecurityStateModel > > This CL refactors the connection_security namespace (a namespace of > statics) into SecurityStateModel, a class attached to a WebContents that > drives the security UI for that WebContents. The SecurityStateModel > provides high-level security information about a page or request, with > the goal of reducing code duplication across various security UI > elements. > > In this first CL, I've introduced the SecurityStateModel and am using it > to drive the omnibox/lock icon, but have not yet adapted WebsiteSettings > to use a SecurityStateModel. > > BUG=528034 > TBR=sky@chromium.org > > Committed: https://crrev.com/83a81afbef8f265815cb6c6a48690511825a1ce5 > Cr-Commit-Position: refs/heads/master@{#347775} TBR=palmer@chromium.org,lgarron@chromium.org,pkasting@chromium.org,tedchoc@chromium.org,avi@chromium.org,sky@chromium.org,dzhioev@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=528034 Committed: https://crrev.com/25f9af1b300a9a057ec3e74b3d33bf003156f441 Cr-Commit-Position: refs/heads/master@{#347980}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+601 lines, -1062 lines) Patch
M chrome/android/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java View 5 chunks +9 lines, -14 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/ssl/ConnectionSecurity.java View 1 chunk +29 lines, -0 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/ssl/SecurityStateModel.java View 1 chunk +0 lines, -49 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModel.java View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/android/chrome_web_contents_delegate_android.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/android/chrome_web_contents_delegate_android.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc View 2 chunks +0 lines, -4 lines 0 comments Download
A chrome/browser/ssl/connection_security.h View 1 chunk +121 lines, -0 lines 0 comments Download
A chrome/browser/ssl/connection_security.cc View 1 chunk +238 lines, -0 lines 0 comments Download
A chrome/browser/ssl/connection_security_android.h View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/browser/ssl/connection_security_android.cc View 1 chunk +26 lines, -0 lines 0 comments Download
D chrome/browser/ssl/security_state_model.h View 1 chunk +0 lines, -152 lines 0 comments Download
D chrome/browser/ssl/security_state_model.cc View 1 chunk +0 lines, -249 lines 0 comments Download
D chrome/browser/ssl/security_state_model_android.h View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/ssl/security_state_model_android.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/ssl/security_state_model_browser_tests.cc View 1 chunk +0 lines, -331 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 2 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/ui/android/bluetooth_chooser_android.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/android/toolbar/toolbar_model_android.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 8 chunks +17 lines, -50 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/extensions/hosted_app_browser_controller.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/tab_helpers.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/chrome_toolbar_model.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/toolbar/test_toolbar_model.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/toolbar/test_toolbar_model.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model_impl.cc View 5 chunks +16 lines, -23 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model_unittest.cc View 4 chunks +6 lines, -16 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 7 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.h View 1 chunk +1 line, -1 line 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
estark
Created Revert of Refactor connection_security into SecurityStateModel
5 years, 3 months ago (2015-09-09 19:36:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324293003/1
5 years, 3 months ago (2015-09-09 19:36:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 19:37:11 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/25f9af1b300a9a057ec3e74b3d33bf003156f441 Cr-Commit-Position: refs/heads/master@{#347980}
5 years, 3 months ago (2015-09-09 19:38:01 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:02:09 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25f9af1b300a9a057ec3e74b3d33bf003156f441
Cr-Commit-Position: refs/heads/master@{#347980}

Powered by Google App Engine
This is Rietveld 408576698