Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1324023006: change for issue 562 (Closed)

Created:
5 years, 3 months ago by caryclark
Modified:
5 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

change for issue 562 Add a current version of the patch described in issue 562. Of interest: the reference row, which is described in the bug as looking correct draws differently with Ganesh. TBR=senorblanco BUG=skia:562 Committed: https://skia.googlesource.com/skia/+/500ab7562c3b50ec4408c1ebd3618c4cde4b6cb8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M gm/shadows.cpp View 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324023006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324023006/1
5 years, 3 months ago (2015-09-02 15:30:18 UTC) #2
caryclark
Please take a look and see if this matches the intent of your (very old) ...
5 years, 3 months ago (2015-09-02 15:30:56 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-02 15:35:32 UTC) #5
Stephen White
LGTM
5 years, 3 months ago (2015-09-02 15:47:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324023006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324023006/1
5 years, 3 months ago (2015-09-04 12:15:38 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 12:20:35 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/500ab7562c3b50ec4408c1ebd3618c4cde4b6cb8

Powered by Google App Engine
This is Rietveld 408576698