Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1323993004: [heap] Separate scavenger functionality into own file. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Separate scavenger functionality into own file. This moves scavenging functionality into a separate component so that neither the scavenger nor objects-visiting need to be exposed outside the heap. R=hpayer@chromium.org,mlippautz@chromium.org Committed: https://crrev.com/ea25bf05f8fd61f99c928baad63c8101415e8788 Cr-Commit-Position: refs/heads/master@{#30712}

Patch Set 1 #

Patch Set 2 : Fix on 64bit archs. #

Patch Set 3 : Remove obsolete header. #

Patch Set 4 : Move visitors. #

Patch Set 5 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+645 lines, -542 lines) Patch
M BUILD.gn View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 2 3 4 8 chunks +4 lines, -19 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 13 chunks +14 lines, -493 lines 0 comments Download
M src/heap/heap-inl.h View 1 2 3 4 3 chunks +1 line, -30 lines 0 comments Download
M src/heap/object-stats.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A src/heap/scavenger.h View 1 2 3 1 chunk +72 lines, -0 lines 0 comments Download
A src/heap/scavenger.cc View 1 2 3 4 1 chunk +496 lines, -0 lines 0 comments Download
A src/heap/scavenger-inl.h View 1 2 3 1 chunk +51 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Michael Starzinger
5 years, 3 months ago (2015-09-04 09:31:16 UTC) #2
Michael Lippautz
Benchmark results seem to be fine, i.e., all numbers within noise. I don't see why ...
5 years, 3 months ago (2015-09-04 13:45:07 UTC) #3
Michael Starzinger
Thanks. Yes, I definitely want to get Hannes' opinion on this too.
5 years, 3 months ago (2015-09-04 15:00:41 UTC) #4
Hannes Payer (out of office)
LGTM, no performance impact.
5 years, 3 months ago (2015-09-14 10:34:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323993004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323993004/80001
5 years, 3 months ago (2015-09-14 10:52:41 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 3 months ago (2015-09-14 11:44:27 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-14 11:44:42 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/ea25bf05f8fd61f99c928baad63c8101415e8788
Cr-Commit-Position: refs/heads/master@{#30712}

Powered by Google App Engine
This is Rietveld 408576698