Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 132393007: Disable NEON procs for SkBlitMask_D32_A8 until we can diagnose the source of the SIGILL chrashes se… (Closed)

Created:
6 years, 11 months ago by djsollen
Modified:
6 years, 10 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Disable NEON procs for SkBlitMask_D32_A8 until we can diagnose the source of the SIGILL chrashes seen in chromium. BUG=2067 Committed: http://code.google.com/p/skia/source/detail?r=13351

Patch Set 1 #

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/opts/SkBlitMask_opts_arm.cpp View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
djsollen
6 years, 11 months ago (2014-01-22 19:59:47 UTC) #1
reed1
lgtm should this go into master and then cherry-pick, or just directly into the branch ...
6 years, 11 months ago (2014-01-22 20:10:32 UTC) #2
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 10 months ago (2014-02-03 19:25:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/132393007/50001
6 years, 10 months ago (2014-02-03 19:26:03 UTC) #4
reed1
lets land in master and cherry-pick back, and file a skia-bug to track fixing this.
6 years, 10 months ago (2014-02-03 19:26:51 UTC) #5
djsollen
On 2014/02/03 19:26:51, reed1 wrote: > lets land in master and cherry-pick back, and file ...
6 years, 10 months ago (2014-02-03 19:31:10 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-03 19:49:10 UTC) #7
commit-bot: I haz the power
List of reviewers changed. mtklein@google.com did a drive-by without LGTM'ing!
6 years, 10 months ago (2014-02-03 19:49:11 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 19:49:18 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 19:51:23 UTC) #10
reed1
The CQ bit was checked by reed@google.com
6 years, 10 months ago (2014-02-06 21:27:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/132393007/50001
6 years, 10 months ago (2014-02-06 21:27:33 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-06 21:27:42 UTC) #13
Message was sent while issue was closed.
Change committed as 13351

Powered by Google App Engine
This is Rietveld 408576698