Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: src/opts/SkBlitMask_opts_arm.cpp

Issue 132393007: Disable NEON procs for SkBlitMask_D32_A8 until we can diagnose the source of the SIGILL chrashes se… (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: fix typo Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/opts/SkBlitMask_opts_arm.cpp
diff --git a/src/opts/SkBlitMask_opts_arm.cpp b/src/opts/SkBlitMask_opts_arm.cpp
index 2bf760313c1edaa09072bab379d6bb01f33c6362..5cac6c8fc75b4d667c2486b9c8dd10ffccd8daba 100644
--- a/src/opts/SkBlitMask_opts_arm.cpp
+++ b/src/opts/SkBlitMask_opts_arm.cpp
@@ -11,6 +11,8 @@ SkBlitMask::ColorProc SkBlitMask::PlatformColorProcs(SkBitmap::Config dstConfig,
#if SK_ARM_NEON_IS_NONE
return NULL;
#else
+/* ** This has been disabled until we can diagnose and fix the SIGILL generated
+ ** in the NEON code. See http://skbug.com/2067 for details.
#if SK_ARM_NEON_IS_DYNAMIC
if (!sk_cpu_arm_has_neon()) {
return NULL;
@@ -20,6 +22,7 @@ SkBlitMask::ColorProc SkBlitMask::PlatformColorProcs(SkBitmap::Config dstConfig,
(SkMask::kA8_Format == maskFormat)) {
return D32_A8_Factory_neon(color);
}
+*/
#endif
// We don't need to handle the SkMask::kLCD16_Format case as the default
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698