components/translate/core/browser/translate_language_list.cc - Issue 1323923002: Remove use of JSONReader::DeprecatedRead from components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/browser/translate_language_list.cc

Issue 1323923002: Remove use of JSONReader::DeprecatedRead from components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Error fix Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/proximity_auth/wire_message.cc ('k') | components/web_resource/promo_resource_service_mobile_ntp_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/core/browser/translate_language_list.cc

diff --git a/components/translate/core/browser/translate_language_list.cc b/components/translate/core/browser/translate_language_list.cc

index d3dcac83f8a17d58e0a4d219e8e2bb7bfe60983d..a9ce3319d14381cc3571d3255fa14d1df3a46245 100644

--- a/components/translate/core/browser/translate_language_list.cc

+++ b/components/translate/core/browser/translate_language_list.cc

@@ -289,8 +289,8 @@ bool TranslateLanguageList::SetSupportedLanguages(

// "al": {"XX": 1, ...}

// }

// Where "tl" and "al" are set in kTargetLanguagesKey and kAlphaLanguagesKey.

- scoped_ptr<base::Value> json_value(base::JSONReader::DeprecatedRead(

- language_list, base::JSON_ALLOW_TRAILING_COMMAS));

+ scoped_ptr<base::Value> json_value =

+ base::JSONReader::Read(language_list, base::JSON_ALLOW_TRAILING_COMMAS);

if (json_value == NULL || !json_value->IsType(base::Value::TYPE_DICTIONARY)) {

NotifyEvent(__LINE__, "Language list is invalid");

« no previous file with comments | « components/proximity_auth/wire_message.cc ('k') | components/web_resource/promo_resource_service_mobile_ntp_unittest.cc » ('j') | no next file with comments »