components/web_resource/promo_resource_service_mobile_ntp_unittest.cc - Issue 1323923002: Remove use of JSONReader::DeprecatedRead from components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_resource/promo_resource_service_mobile_ntp_unittest.cc

Issue 1323923002: Remove use of JSONReader::DeprecatedRead from components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Error fix Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/translate/core/browser/translate_language_list.cc ('k') | components/web_resource/promo_resource_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_resource/promo_resource_service_mobile_ntp_unittest.cc

diff --git a/components/web_resource/promo_resource_service_mobile_ntp_unittest.cc b/components/web_resource/promo_resource_service_mobile_ntp_unittest.cc

index 98648373a90e815794d6824f992bffc5e70c837f..760b7eb85553592a24955edaf241eeec24974260 100644

--- a/components/web_resource/promo_resource_service_mobile_ntp_unittest.cc

+++ b/components/web_resource/promo_resource_service_mobile_ntp_unittest.cc

@@ -52,10 +52,10 @@ class NotificationPromoMobileNtpTest {

const std::string& promo_action_type,

const std::string& promo_action_arg0,

const std::string& promo_action_arg1) {

- base::Value* value(base::JSONReader::DeprecatedRead(json));

+ scoped_ptr<base::Value> value = base::JSONReader::Read(json);

ASSERT_TRUE(value);

base::DictionaryValue* dict = NULL;

- value->GetAsDictionary(&dict);

+ value.release()->GetAsDictionary(&dict);

ASSERT_TRUE(dict);

test_json_.reset(dict);