Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1323923002: Remove use of JSONReader::DeprecatedRead from components/ (Closed)

Created:
5 years, 3 months ago by Olli Raula
Modified:
5 years, 3 months ago
CC:
chromium-reviews, markusheintz_, raymes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove use of JSONReader::DeprecatedRead from components/ Remove use of deprecated function DeprecatedRead from components/ Also made some refactoring components/webcrypto/test/test_helpers.cc/h BUG=523194 Committed: https://crrev.com/1fd91c70f8c992018fb3e7216f306bc080b726db Cr-Commit-Position: refs/heads/master@{#347696}

Patch Set 1 #

Patch Set 2 : Fix the error #

Patch Set 3 : Fix and two more files #

Patch Set 4 : Error fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -36 lines) Patch
M components/content_settings/core/browser/content_settings_policy_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/dom_distiller/core/page_features_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/dom_distiller/ios/distiller_page_ios.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M components/history/core/browser/web_history_service.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M components/json_schema/json_schema_validator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/policy/core/browser/configuration_policy_handler_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M components/policy/core/common/cloud/component_cloud_policy_store.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/policy/tools/generate_policy_source.py View 1 chunk +2 lines, -2 lines 0 comments Download
M components/proximity_auth/remote_status_update_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/wire_message.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/translate/core/browser/translate_language_list.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/web_resource/promo_resource_service_mobile_ntp_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M components/web_resource/promo_resource_service_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/webcrypto/test/test_helpers.cc View 1 2 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Olli Raula
Could you review
5 years, 3 months ago (2015-09-07 11:48:22 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-08 12:30:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323923002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323923002/60001
5 years, 3 months ago (2015-09-08 12:32:11 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-08 13:43:38 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 13:44:34 UTC) #7
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/1fd91c70f8c992018fb3e7216f306bc080b726db
Cr-Commit-Position: refs/heads/master@{#347696}

Powered by Google App Engine
This is Rietveld 408576698