Issue 1323863003: Fix invalid cast of heap constant object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1323863003: Fix invalid cast of heap constant object. (Closed)

Created:
5 years, 3 months ago by pcc1

Modified:
5 years, 3 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Fix invalid cast of heap constant object. Previously we were casting to Operator1<Unique<Object>>, instead of the correct type for heap constant objects, Operator1<Unique<HeapObject>>. Cleanup for cfi_vptr=1; see https://www.chromium.org/developers/testing/control-flow-integrity BUG=chromium:457523 R=bmeurer@chromium.org LOG=N

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/compiler/representation-change.h	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

pcc

5 years, 3 months ago (2015-09-01 05:26:55 UTC) #3

On 2015/09/01 04:17:40, pcc1 wrote:
> Did you miss this one?

Looks like this is redundant with https://codereview.chromium.org/1314473007;
closing.