Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 1323863002: Image generator-backed SkPictureShader (Closed)

Created:
5 years, 3 months ago by f(malita)
Modified:
5 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -40 lines) Patch
M src/core/SkPictureShader.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/core/SkPictureShader.cpp View 5 chunks +14 lines, -36 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
f(malita)
5 years, 3 months ago (2015-08-31 22:41:16 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323863002/1
5 years, 3 months ago (2015-08-31 22:45:42 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-31 22:50:34 UTC) #5
reed1
do we already have GMs exercising this? lgtm
5 years, 3 months ago (2015-09-01 02:04:40 UTC) #6
f(malita)
On 2015/09/01 02:04:40, reed1 wrote: > do we already have GMs exercising this? Yup, pictureshader ...
5 years, 3 months ago (2015-09-01 02:53:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323863002/1
5 years, 3 months ago (2015-09-01 02:53:29 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 02:54:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ddc4b46c340d4572e1c29e97d5a85b4d76b9c577

Powered by Google App Engine
This is Rietveld 408576698