Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: mojo/nacl/mojo_interface_nacl_nonsfi.h

Issue 1323823002: Adding nonsfi content handler (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Responding to Code Review Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/nacl/mojo_interface_nacl_nonsfi.h
diff --git a/mojo/nacl/mojo_interface_nacl_nonsfi.h b/mojo/nacl/mojo_interface_nacl_nonsfi.h
new file mode 100644
index 0000000000000000000000000000000000000000..1f47829916a18f724fa091c555097fbef196591e
--- /dev/null
+++ b/mojo/nacl/mojo_interface_nacl_nonsfi.h
@@ -0,0 +1,22 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MOJO_INTERFACE_NACL_NONSFI_H_
Mark Seaborn 2015/09/01 21:05:46 Style nit: I believe these #define names are suppo
Sean Klein 2015/09/01 22:55:27 Done.
+#define MOJO_INTERFACE_NACL_NONSFI_H_
+
+#include "mojo/public/c/system/functions.h"
+#include "mojo/public/platform/nacl/mojo_irt.h"
Mark Seaborn 2015/09/01 21:05:46 Nit: not needed, following #include-what-you-use.
Sean Klein 2015/09/01 22:55:27 Done.
+#include "native_client/src/public/irt_core.h"
Mark Seaborn 2015/09/01 21:05:46 Also not needed. You just need stdlib.h for size_
Sean Klein 2015/09/01 22:55:27 Done -- though stdlib is not needed either.
+
+// Used to pass handle to application. If uncalled,
+// the handle defaults to MOJO_HANDLE_INVALID.
+void mojo_set_initial_handle(MojoHandle handle);
Mark Seaborn 2015/09/01 21:05:46 Can you use CamelCase and put these in a namespace
Sean Klein 2015/09/01 22:55:27 Done.
+
+// Standard mojo nonsfi query function which may be passed to
Mark Seaborn 2015/09/01 21:05:46 Can you say "IRT interface query function" to add
Sean Klein 2015/09/01 22:55:27 Done.
+// nacl_irt_nonsfi_entry. Queries for a mojo interface, then for
+// the irt core.
+size_t mojo_irt_nonsfi_query(const char* interface_ident,
+ void* table, size_t tablesize);
+
+#endif // MOJO_INTERFACE_NACL_NONSFI_H_

Powered by Google App Engine
This is Rietveld 408576698