Adding nonsfi content handler

mojo/nacl/mojo_interface_nacl_nonsfi.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MOJO_INTERFACE_NACL_NONSFI_H_

[Mark Seaborn, 2015/09/01 21:05:46]

Style nit: I believe these #define names are supposed to follow the full
pathname, to avoid potential clashes, i.e.
MOJO_NACL_MOJO_INTERFACE_NACL_NONSFI_H_.

[Sean Klein, 2015/09/01 22:55:27]

Done.

+#define MOJO_INTERFACE_NACL_NONSFI_H_
+
+#include "mojo/public/c/system/functions.h"
+#include "mojo/public/platform/nacl/mojo_irt.h"

[Mark Seaborn, 2015/09/01 21:05:46]

Nit: not needed, following #include-what-you-use.

[Sean Klein, 2015/09/01 22:55:27]

Done.

+#include "native_client/src/public/irt_core.h"

[Mark Seaborn, 2015/09/01 21:05:46]

Also not needed.  You just need stdlib.h for size_t.

[Sean Klein, 2015/09/01 22:55:27]

Done -- though stdlib is not needed either.

+
+// Used to pass handle to application. If uncalled,
+// the handle defaults to MOJO_HANDLE_INVALID.
+void mojo_set_initial_handle(MojoHandle handle);

[Mark Seaborn, 2015/09/01 21:05:46]

Can you use CamelCase and put these in a namespace, following Chromium C++
style, please?

underscore_naming_style is from the NaCl codebase, and it's always been oddly
inconsistent that NaCl uses that in untrusted code but not in trusted code.

[Sean Klein, 2015/09/01 22:55:27]

Done.

+
+// Standard mojo nonsfi query function which may be passed to

[Mark Seaborn, 2015/09/01 21:05:46]

Can you say "IRT interface query function" to add more context?

[Sean Klein, 2015/09/01 22:55:27]

Done.

+// nacl_irt_nonsfi_entry. Queries for a mojo interface, then for
+// the irt core.
+size_t mojo_irt_nonsfi_query(const char* interface_ident,
+                             void* table, size_t tablesize);
+
+#endif // MOJO_INTERFACE_NACL_NONSFI_H_