chrome/browser/metrics/chrome_metrics_service_client.cc - Issue 1323703002: Add tests for Chrome Stability Metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 1323703002: Add tests for Chrome Stability Metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change to testing::Test and add extension test Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/chrome_metrics_service_client.cc

diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc

index f7f44b52ba5f9ec993eded2bf4e5ea1a86288412..bf5b391e864a70a2e449a5547e18cd2c5a434c6b 100644

--- a/chrome/browser/metrics/chrome_metrics_service_client.cc

+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc

@@ -315,7 +315,8 @@ void ChromeMetricsServiceClient::Initialize() {

scoped_ptr<metrics::MetricsProvider>(new OmniboxMetricsProvider(

base::Bind(&chrome::IsOffTheRecordSessionActive))));

metrics_service_->RegisterMetricsProvider(

- scoped_ptr<metrics::MetricsProvider>(new ChromeStabilityMetricsProvider));

+ scoped_ptr<metrics::MetricsProvider>(new ChromeStabilityMetricsProvider(

+ g_browser_process->local_state())));

metrics_service_->RegisterMetricsProvider(

scoped_ptr<metrics::MetricsProvider>(new metrics::GPUMetricsProvider));