Add tests for Chrome Stability Metrics.

Add tests for Chrome Stability Metrics.

BUG=526198, 467920
Committed: https://crrev.com/32a86c2579e167dd1e181676056c202f5191852d
Cr-Commit-Position: refs/heads/master@{#346436}

Committed: https://crrev.com/877e238133becc8f37b026584612210ee727ddb4
Cr-Commit-Position: refs/heads/master@{#346956}

[Will Harris, 2015-08-30 00:49:19]

wfh@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Will Harris, 2015-08-30 00:49:38]

PTAL

[Alexei Svitkine (slow), 2015-08-31 15:12:26]

LGTM - thanks for fixing this up!

https://codereview.chromium.org/1323703002/diff/1/chrome/browser/metrics/chro...
File chrome/browser/metrics/chrome_stability_metrics_provider_unittest.cc
(right):

https://codereview.chromium.org/1323703002/diff/1/chrome/browser/metrics/chro...
chrome/browser/metrics/chrome_stability_metrics_provider_unittest.cc:24: using
namespace content;
Nit: In metrics/ code, we prefer not to have using declarations.

https://codereview.chromium.org/1323703002/diff/1/chrome/browser/metrics/chro...
chrome/browser/metrics/chrome_stability_metrics_provider_unittest.cc:46:
TestBrowserThreadBundle thread_bundle;
Nit: This can be a member of the test harness class, since you're using it in
all the tests.

https://codereview.chromium.org/1323703002/diff/1/chrome/browser/metrics/chro...
chrome/browser/metrics/chrome_stability_metrics_provider_unittest.cc:63:
EXPECT_EQ(stability.child_process_crash_count(), 2);
Nit: Expected value should be on the left. Please fix here and on line 100.

[Will Harris, 2015-08-31 18:18:35]

thanks for the review

https://codereview.chromium.org/1323703002/diff/1/chrome/browser/metrics/chro...
File chrome/browser/metrics/chrome_stability_metrics_provider_unittest.cc
(right):

https://codereview.chromium.org/1323703002/diff/1/chrome/browser/metrics/chro...
chrome/browser/metrics/chrome_stability_metrics_provider_unittest.cc:24: using
namespace content;
On 2015/08/31 15:12:26, Alexei Svitkine wrote:
> Nit: In metrics/ code, we prefer not to have using declarations.

Done.

https://codereview.chromium.org/1323703002/diff/1/chrome/browser/metrics/chro...
chrome/browser/metrics/chrome_stability_metrics_provider_unittest.cc:46:
TestBrowserThreadBundle thread_bundle;
On 2015/08/31 15:12:26, Alexei Svitkine wrote:
> Nit: This can be a member of the test harness class, since you're using it in
> all the tests.

Done.

https://codereview.chromium.org/1323703002/diff/1/chrome/browser/metrics/chro...
chrome/browser/metrics/chrome_stability_metrics_provider_unittest.cc:63:
EXPECT_EQ(stability.child_process_crash_count(), 2);
On 2015/08/31 15:12:26, Alexei Svitkine wrote:
> Nit: Expected value should be on the left. Please fix here and on line 100.

Done.

[Will Harris, 2015-08-31 18:19:05]

The CQ bit was checked by wfh@chromium.org

[Will Harris, 2015-08-31 18:19:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1323703002/#ps20001
(title: "code review comments")

[commit-bot: I haz the power, 2015-08-31 18:19:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323703002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323703002/20001

[commit-bot: I haz the power, 2015-08-31 19:16:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-31 19:17:23]

Patchset 2 (id:??) landed as
https://crrev.com/32a86c2579e167dd1e181676056c202f5191852d
Cr-Commit-Position: refs/heads/master@{#346436}

[Will Harris, 2015-09-01 04:16:52]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1321313002/ by wfh@chromium.org.

The reason for reverting is: can't use extensions::ExtensionTest in chrome
unit_tests, only in extensions_unittests. need to rethink this test..

[Will Harris, 2015-09-02 00:35:13]

this is now fixed, I no longer use the extensions::ExtensionsTest (I should have
rtfm before using) and instead create a renderviewhost, which has the advantage
that I can now test both renderer and extension metrics.

PTAL

[Avi (use Gerrit), 2015-09-02 01:11:09]

avi@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2015-09-02 01:11:10]

https://codereview.chromium.org/1323703002/diff/40001/chrome/browser/metrics/...
File chrome/browser/metrics/chrome_stability_metrics_provider.h (right):

https://codereview.chromium.org/1323703002/diff/40001/chrome/browser/metrics/...
chrome/browser/metrics/chrome_stability_metrics_provider.h:71: // Increment an
Integer pref value specified by |path|
. at the end of sentences

https://codereview.chromium.org/1323703002/diff/40001/chrome/browser/metrics/...
chrome/browser/metrics/chrome_stability_metrics_provider.h:74: // Increment a
64-bit Integer pref value specified by |path|
ditto

https://codereview.chromium.org/1323703002/diff/40001/chrome/browser/metrics/...
File chrome/browser/metrics/chrome_stability_metrics_provider_unittest.cc
(right):

https://codereview.chromium.org/1323703002/diff/40001/chrome/browser/metrics/...
chrome/browser/metrics/chrome_stability_metrics_provider_unittest.cc:1: //
Copyright 2014 The Chromium Authors. All rights reserved.
It's 2015.

[Avi (use Gerrit), 2015-09-02 01:11:16]

avi@chromium.org changed reviewers:
- avi@chromium.org

[Will Harris, 2015-09-02 15:57:54]

asvitkine -> do you want to take another look at the new tests?

https://codereview.chromium.org/1323703002/diff/40001/chrome/browser/metrics/...
File chrome/browser/metrics/chrome_stability_metrics_provider.h (right):

https://codereview.chromium.org/1323703002/diff/40001/chrome/browser/metrics/...
chrome/browser/metrics/chrome_stability_metrics_provider.h:71: // Increment an
Integer pref value specified by |path|
On 2015/09/02 01:11:10, Avi wrote:
> . at the end of sentences

Done.

https://codereview.chromium.org/1323703002/diff/40001/chrome/browser/metrics/...
chrome/browser/metrics/chrome_stability_metrics_provider.h:74: // Increment a
64-bit Integer pref value specified by |path|
On 2015/09/02 01:11:10, Avi wrote:
> ditto

Done.

https://codereview.chromium.org/1323703002/diff/40001/chrome/browser/metrics/...
File chrome/browser/metrics/chrome_stability_metrics_provider_unittest.cc
(right):

https://codereview.chromium.org/1323703002/diff/40001/chrome/browser/metrics/...
chrome/browser/metrics/chrome_stability_metrics_provider_unittest.cc:1: //
Copyright 2014 The Chromium Authors. All rights reserved.
On 2015/09/02 01:11:10, Avi wrote:
> It's 2015.

Done.

[Alexei Svitkine (slow), 2015-09-02 16:34:17]

lgtm

[Will Harris, 2015-09-02 16:34:51]

The CQ bit was checked by wfh@chromium.org

[commit-bot: I haz the power, 2015-09-02 16:34:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323703002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323703002/60001

[commit-bot: I haz the power, 2015-09-02 17:33:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-02 17:34:30]

Patchset 4 (id:??) landed as
https://crrev.com/877e238133becc8f37b026584612210ee727ddb4
Cr-Commit-Position: refs/heads/master@{#346956}