Prepare for computation of NewStructure in Resolution.

Prepare for computation of NewStructure in Resolution.

BUG=
R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/1a8f32efc441c4f8603b0d8c83b82d326dbc5d4c

Reverted: https://github.com/dart-lang/sdk/commit/db89bc6574859b93434e98e68bcbe15f0330ab9e

Committed: https://github.com/dart-lang/sdk/commit/ae721be5ae81ce07c59b673652bb0d4fd5e0f96b

[Johnni Winther, 2015-08-28 15:48:44]

johnniwinther@google.com changed reviewers:
+ karlklose@google.com, sigmund@google.com

[Johnni Winther, 2015-09-01 07:25:05]

ping

[karlklose, 2015-09-01 07:56:32]

LGTM.

[Johnni Winther, 2015-09-01 08:11:27]

Committed patchset #2 (id:20001) manually as
1a8f32efc441c4f8603b0d8c83b82d326dbc5d4c (presubmit successful).

[Johnni Winther, 2015-09-01 08:52:49]

PTAL at the last patch

[karlklose, 2015-09-01 10:21:37]

LGTM.

[Johnni Winther, 2015-09-01 10:40:02]

Committed patchset #4 (id:60001) manually as
ae721be5ae81ce07c59b673652bb0d4fd5e0f96b (presubmit successful).

[Siggi Cherem (dart-lang), 2015-09-01 20:13:40]

oops - I had some comments the other day and I forgot to hit send.

https://codereview.chromium.org/1323573002/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/class_members.dart (right):

https://codereview.chromium.org/1323573002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/class_members.dart:383: "declaring class:
${cls}."));
Not sure I follow the message, does this indicate a circular type hierarchy
issue? Maybe call that out explicitly in the message?

https://codereview.chromium.org/1323573002/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/constructors.dart (right):

https://codereview.chromium.org/1323573002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/constructors.dart:567: //if
(Elements.isUnresolved(element)) return element;
delete or do we need to deal with unresolved elements somewhere here?

[Siggi Cherem (dart-lang), 2015-09-01 20:14:14]

https://codereview.chromium.org/1323573002/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/constructors.dart (right):

https://codereview.chromium.org/1323573002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/constructors.dart:567: //if
(Elements.isUnresolved(element)) return element;
On 2015/09/01 20:13:40, Siggi Cherem (dart-lang) wrote:
> delete or do we need to deal with unresolved elements somewhere here?

I see that this is now addressed in the latest patch with an assertion. Never
mind.