Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4077)

Unified Diff: chrome/common/extensions/api/downloads.idl

Issue 132353002: Change chrome.downloads.DownloadItem.{fileSize,bytesReceived,totalBytes} from longs to doubles for … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/downloads.idl
diff --git a/chrome/common/extensions/api/downloads.idl b/chrome/common/extensions/api/downloads.idl
index e13d3aade6d1605fee37f5b445c97f8d2fdd9a66..cd7739ccd260378ac0eda6752fecb3109840cfe3 100644
--- a/chrome/common/extensions/api/downloads.idl
+++ b/chrome/common/extensions/api/downloads.idl
@@ -189,14 +189,14 @@ namespace downloads {
// Number of bytes received so far from the host, without considering file
// compression.
- long bytesReceived;
+ double bytesReceived;
// Number of bytes in the whole file, without considering file compression,
// or -1 if unknown.
- long totalBytes;
+ double totalBytes;
// Number of bytes in the whole file post-decompression, or -1 if unknown.
- long fileSize;
+ double fileSize;
// Whether the downloaded file still exists. This information may be out of
// date because Chrome does not automatically watch for file removal. Call
@@ -244,11 +244,11 @@ namespace downloads {
// Limits results to $ref:DownloadItem whose
// <code>totalBytes</code> is greater than the given integer.
- long? totalBytesGreater;
+ double? totalBytesGreater;
// Limits results to $ref:DownloadItem whose
// <code>totalBytes</code> is less than the given integer.
- long? totalBytesLess;
+ double? totalBytesLess;
// Limits results to $ref:DownloadItem whose
// <code>filename</code> matches the given regular expression.
@@ -304,14 +304,14 @@ namespace downloads {
// Number of bytes received so far from the host, without considering file
// compression.
- long? bytesReceived;
+ double? bytesReceived;
// Number of bytes in the whole file, without considering file compression,
// or -1 if unknown.
- long? totalBytes;
+ double? totalBytes;
// Number of bytes in the whole file post-decompression, or -1 if unknown.
- long? fileSize;
+ double? fileSize;
// Whether the downloaded file exists;
boolean? exists;
@@ -327,6 +327,11 @@ namespace downloads {
long? current;
};
+ dictionary DoubleDelta {
+ double? previous;
+ double? current;
+ };
+
dictionary BooleanDelta {
boolean? previous;
boolean? current;
@@ -369,10 +374,10 @@ namespace downloads {
StringDelta? error;
// The change in <code>totalBytes</code>, if any.
- LongDelta? totalBytes;
+ DoubleDelta? totalBytes;
// The change in <code>fileSize</code>, if any.
- LongDelta? fileSize;
+ DoubleDelta? fileSize;
// The change in <code>exists</code>, if any.
BooleanDelta? exists;
« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698