chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc - Issue 132353002: Change chrome.downloads.DownloadItem.{fileSize,bytesReceived,totalBytes} from longs to doubles for …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

Issue 132353002: Change chrome.downloads.DownloadItem.{fileSize,bytesReceived,totalBytes} from longs to doubles for … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api.cc ('k') | chrome/common/extensions/api/downloads.idl » ('j') | chrome/common/extensions/api/downloads.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

index 9dbf2e8b8c3899469059234eb9b4a5d0b1d579da..160681aaa67d9acf62bfaa11debd331ca0f70227 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

@@ -1943,7 +1943,8 @@ IN_PROC_BROWSER_TEST_F(DownloadExtensionTest,

content::DOWNLOAD_INTERRUPT_REASON_SERVER_BAD_CONTENT,

base::StringPrintf("[{\"danger\": \"safe\","

" \"incognito\": false,"

- " \"bytesReceived\": 0,"

+ " \"bytesReceived\": 0.0,"

+ " \"fileSize\": 0.0,"

" \"mime\": \"\","

" \"paused\": false,"

" \"url\": \"%s\"}]",

@@ -1980,15 +1981,17 @@ IN_PROC_BROWSER_TEST_F(DownloadExtensionTest,

ASSERT_TRUE(WaitFor(api::OnCreated::kEventName,

base::StringPrintf("[{\"danger\": \"safe\","

- " \"incognito\": false,"

- " \"mime\": \"text/html\","

- " \"paused\": false,"

- " \"url\": \"%s\"}]", download_url.c_str())));

+ " \"incognito\": false,"

+ " \"bytesReceived\": 0.0,"

+ " \"fileSize\": 0.0,"

+ " \"mime\": \"text/html\","

+ " \"paused\": false,"

+ " \"url\": \"%s\"}]", download_url.c_str())));

ASSERT_TRUE(WaitFor(api::OnChanged::kEventName,

base::StringPrintf("[{\"id\": %d,"

- " \"state\": {"

- " \"previous\": \"in_progress\","

- " \"current\": \"complete\"}}]", result_id)));

+ " \"state\": {"

+ " \"previous\": \"in_progress\","

+ " \"current\": \"complete\"}}]", result_id)));

}

// Test that DownloadsDownloadFunction propagates the |method| and |body|