Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 132343007: Add top level build script for building packages. (Closed)

Created:
6 years, 11 months ago by Sam Clegg
Modified:
6 years, 11 months ago
Reviewers:
bradnelson, bradn, binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Add top level build script for building packages. This takes a lot of the builderplate out of the individual build.sh script and puts it in a central script: naclports.sh. This script drives building of packages and include common.sh and the package specific build.sh. This is one step towards a more centrally controled build environment where each step of the build can be run, and logged separately, making the build output easier on the eye (and more like system's like Mac's homebrew). Make the build steps for each package more independent. The idea being that they could be run as separate processes in the future. Also update the top level README to use 'package' rather than 'port' where is makes sense. R=binji@chromium.org, bradnelson@google.com Committed: https://code.google.com/p/naclports/source/detail?r=1052

Patch Set 1 : #

Patch Set 2 : #

Total comments: 14

Patch Set 3 : fixes based on feedback #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -878 lines) Patch
M Makefile View 1 2 1 chunk +1 line, -1 line 0 comments Download
M README.rst View 1 5 chunks +8 lines, -8 lines 0 comments Download
M build_tools/common.sh View 1 2 10 chunks +28 lines, -33 lines 0 comments Download
M build_tools/nacl_env.sh View 1 2 1 chunk +23 lines, -21 lines 0 comments Download
A build_tools/naclports.sh View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
M ports/DevIL/build.sh View 2 chunks +0 lines, -6 lines 0 comments Download
M ports/FreeImage/build.sh View 2 chunks +0 lines, -6 lines 0 comments Download
M ports/ImageMagick/build.sh View 2 chunks +0 lines, -6 lines 0 comments Download
M ports/Mesa/build.sh View 3 chunks +2 lines, -7 lines 0 comments Download
M ports/OpenSceneGraph/build.sh View 3 chunks +7 lines, -9 lines 0 comments Download
M ports/Regal/build.sh View 2 chunks +0 lines, -6 lines 0 comments Download
M ports/SDL/build.sh View 1 2 3 4 chunks +5 lines, -11 lines 0 comments Download
M ports/SDL_image/build.sh View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M ports/SDL_mixer/build.sh View 2 chunks +0 lines, -6 lines 0 comments Download
M ports/SDL_net/build.sh View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M ports/SDL_ttf/build.sh View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M ports/agg/build.sh View 2 chunks +0 lines, -6 lines 0 comments Download
M ports/apr-util/build.sh View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M ports/apr/build.sh View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M ports/bash/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/bochs/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/boost/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/box2d/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/bullet/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/busybox/build.sh View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M ports/bzip2/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/cairo/build.sh View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
M ports/cfitsio/build.sh View 1 2 1 chunk +0 lines, -20 lines 0 comments Download
M ports/civetweb/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/clapack/build.sh View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M ports/crypto_ext/build.sh View 1 chunk +0 lines, -1 line 0 comments Download
M ports/curl/build.sh View 3 chunks +0 lines, -6 lines 0 comments Download
M ports/dosbox/build.sh View 2 chunks +0 lines, -6 lines 0 comments Download
M ports/dreadthread/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/drod/build.sh View 3 chunks +3 lines, -14 lines 0 comments Download
M ports/expat/build.sh View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M ports/faac/build.sh View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
M ports/faad2/build.sh View 1 chunk +0 lines, -5 lines 0 comments Download
M ports/ffmpeg/build.sh View 2 chunks +0 lines, -6 lines 0 comments Download
M ports/fftw/build.sh View 3 chunks +1 line, -6 lines 0 comments Download
M ports/flac/build.sh View 2 chunks +0 lines, -6 lines 0 comments Download
M ports/fontconfig/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/freealut/build.sh View 1 chunk +0 lines, -5 lines 0 comments Download
M ports/freetype/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/gc/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/gdb/build.sh View 3 chunks +0 lines, -8 lines 0 comments Download
M ports/giflib/build.sh View 2 chunks +0 lines, -6 lines 0 comments Download
M ports/git/build.sh View 3 chunks +1 line, -6 lines 0 comments Download
M ports/glib/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/glibc-compat/build.sh View 1 2 3 2 chunks +4 lines, -12 lines 0 comments Download
M ports/gmock/build.sh View 2 chunks +0 lines, -6 lines 0 comments Download
M ports/gmp/build.sh View 1 2 1 chunk +1 line, -6 lines 0 comments Download
M ports/gsl/build.sh View 1 2 2 chunks +0 lines, -15 lines 0 comments Download
M ports/jpeg6b/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/jpeg8d/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/jsoncpp/build.sh View 2 chunks +0 lines, -6 lines 0 comments Download
M ports/lame/build.sh View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M ports/lcms/build.sh View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M ports/leveldb/build.sh View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M ports/libav/build.sh View 2 chunks +0 lines, -6 lines 0 comments Download
M ports/libhangul/build.sh View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M ports/libmikmod/build.sh View 1 chunk +0 lines, -5 lines 0 comments Download
M ports/libmng/build.sh View 2 chunks +2 lines, -6 lines 0 comments Download
M ports/libmodplug/build.sh View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M ports/libogg/build.sh View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M ports/libpng/build.sh View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M ports/libsodium/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/libtar/build.sh View 1 chunk +0 lines, -5 lines 0 comments Download
M ports/libtheora/build.sh View 2 chunks +0 lines, -6 lines 0 comments Download
M ports/libtomcrypt/build.sh View 2 chunks +1 line, -7 lines 0 comments Download
M ports/libtommath/build.sh View 2 chunks +3 lines, -14 lines 0 comments Download
M ports/libvorbis/build.sh View 1 chunk +0 lines, -5 lines 0 comments Download
M ports/libxml2/build.sh View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
M ports/lua5.1/build.sh View 2 chunks +0 lines, -6 lines 0 comments Download
M ports/lua5.2/build.sh View 2 chunks +0 lines, -6 lines 0 comments Download
M ports/lua_ppapi/build.sh View 3 chunks +2 lines, -10 lines 0 comments Download
M ports/make/build.sh View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M ports/mesagl/build.sh View 2 chunks +1 line, -6 lines 0 comments Download
M ports/metakit/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/mongoose/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/mpc/build.sh View 1 2 1 chunk +1 line, -6 lines 0 comments Download
M ports/mpfr/build.sh View 1 2 1 chunk +1 line, -6 lines 0 comments Download
M ports/mpg123/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/nano/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/ncurses/build.sh View 2 chunks +0 lines, -6 lines 0 comments Download
M ports/netcat/build.sh View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M ports/nethack/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/openal-ogg/build.sh View 3 chunks +2 lines, -7 lines 0 comments Download
M ports/openal-soft/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/opencv/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/openssh/build.sh View 3 chunks +0 lines, -8 lines 0 comments Download
M ports/openssl/build.sh View 2 chunks +0 lines, -6 lines 0 comments Download
M ports/pango/build.sh View 2 chunks +0 lines, -6 lines 0 comments Download
M ports/pcre/build.sh View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M ports/physfs/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/pixman/build.sh View 2 chunks +0 lines, -6 lines 0 comments Download
M ports/protobuf/build.sh View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M ports/python/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/python3/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/python3_ppapi/build.sh View 2 chunks +2 lines, -6 lines 0 comments Download
M ports/python_ppapi/build.sh View 2 chunks +2 lines, -6 lines 0 comments Download
M ports/readline/build.sh View 2 chunks +0 lines, -6 lines 0 comments Download
M ports/ruby/build.sh View 3 chunks +0 lines, -8 lines 0 comments Download
M ports/ruby_ppapi/build.sh View 3 chunks +2 lines, -7 lines 0 comments Download
M ports/scummvm/build.sh View 4 chunks +0 lines, -9 lines 0 comments Download
M ports/snes9x/build.sh View 3 chunks +3 lines, -16 lines 0 comments Download
M ports/speex/build.sh View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M ports/sqlite/build.sh View 3 chunks +0 lines, -6 lines 0 comments Download
M ports/subversion/build.sh View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M ports/texlive/build.sh View 3 chunks +0 lines, -6 lines 0 comments Download
M ports/thttpd/build.sh View 2 chunks +0 lines, -6 lines 0 comments Download
M ports/tiff/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/tinyxml/build.sh View 2 chunks +0 lines, -6 lines 0 comments Download
M ports/vim/build.sh View 3 chunks +1 line, -6 lines 0 comments Download
M ports/webp/build.sh View 1 chunk +1 line, -4 lines 0 comments Download
M ports/x264/build.sh View 2 chunks +1 line, -7 lines 0 comments Download
M ports/xaos/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/yajl/build.sh View 2 chunks +2 lines, -8 lines 0 comments Download
M ports/zeromq/build.sh View 2 chunks +0 lines, -5 lines 0 comments Download
M ports/zlib/build.sh View 5 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sam Clegg
6 years, 11 months ago (2014-01-11 02:06:57 UTC) #1
binji
lgtm https://codereview.chromium.org/132343007/diff/50001/build_tools/common.sh File build_tools/common.sh (right): https://codereview.chromium.org/132343007/diff/50001/build_tools/common.sh#newcode14 build_tools/common.sh:14: # and variabled defined here are available in ...
6 years, 11 months ago (2014-01-13 23:05:42 UTC) #2
Sam Clegg
https://codereview.chromium.org/132343007/diff/50001/build_tools/common.sh File build_tools/common.sh (right): https://codereview.chromium.org/132343007/diff/50001/build_tools/common.sh#newcode14 build_tools/common.sh:14: # and variabled defined here are available in the ...
6 years, 11 months ago (2014-01-14 01:54:38 UTC) #3
Sam Clegg
+bradnelson
6 years, 11 months ago (2014-01-15 01:35:32 UTC) #4
bradn
LGTM Land it now, before something changes! :-)
6 years, 11 months ago (2014-01-15 18:10:19 UTC) #5
Sam Clegg
6 years, 11 months ago (2014-01-16 03:11:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r1052 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698