Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1323333004: Renames mandoline_frame_apptests to web_view_apptests (Closed)

Created:
5 years, 3 months ago by sky
Modified:
5 years, 3 months ago
Reviewers:
msw
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renames mandoline_frame_apptests to web_view_apptests BUG=none TEST=none R=msw@chromium.org Committed: https://crrev.com/84fec63dbc6667f4c1e03eed4b6f11b4c9865a40 Cr-Commit-Position: refs/heads/master@{#347984}

Patch Set 1 #

Total comments: 6

Patch Set 2 : order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M components/web_view/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M mandoline/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/tools/data/apptests View 1 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
sky
5 years, 3 months ago (2015-09-09 17:43:23 UTC) #1
msw
https://codereview.chromium.org/1323333004/diff/1/components/web_view/BUILD.gn File components/web_view/BUILD.gn (right): https://codereview.chromium.org/1323333004/diff/1/components/web_view/BUILD.gn#newcode86 components/web_view/BUILD.gn:86: output_name = "web_view_apptests" I think we need to specify ...
5 years, 3 months ago (2015-09-09 18:11:47 UTC) #2
sky
https://codereview.chromium.org/1323333004/diff/1/components/web_view/BUILD.gn File components/web_view/BUILD.gn (right): https://codereview.chromium.org/1323333004/diff/1/components/web_view/BUILD.gn#newcode86 components/web_view/BUILD.gn:86: output_name = "web_view_apptests" On 2015/09/09 18:11:47, msw wrote: > ...
5 years, 3 months ago (2015-09-09 18:14:28 UTC) #3
msw
lgtm https://codereview.chromium.org/1323333004/diff/1/components/web_view/BUILD.gn File components/web_view/BUILD.gn (right): https://codereview.chromium.org/1323333004/diff/1/components/web_view/BUILD.gn#newcode86 components/web_view/BUILD.gn:86: output_name = "web_view_apptests" On 2015/09/09 18:14:28, sky wrote: ...
5 years, 3 months ago (2015-09-09 18:20:22 UTC) #4
sky
https://codereview.chromium.org/1323333004/diff/1/components/web_view/BUILD.gn File components/web_view/BUILD.gn (right): https://codereview.chromium.org/1323333004/diff/1/components/web_view/BUILD.gn#newcode86 components/web_view/BUILD.gn:86: output_name = "web_view_apptests" On 2015/09/09 18:14:28, sky wrote: > ...
5 years, 3 months ago (2015-09-09 18:20:32 UTC) #5
msw
oh, one nit... https://codereview.chromium.org/1323333004/diff/1/mojo/tools/data/apptests File mojo/tools/data/apptests (right): https://codereview.chromium.org/1323333004/diff/1/mojo/tools/data/apptests#newcode83 mojo/tools/data/apptests:83: 'test': 'mojo:web_view_apptests', nit: abc order?
5 years, 3 months ago (2015-09-09 18:20:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323333004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323333004/1
5 years, 3 months ago (2015-09-09 18:25:49 UTC) #8
sky
https://codereview.chromium.org/1323333004/diff/1/mojo/tools/data/apptests File mojo/tools/data/apptests (right): https://codereview.chromium.org/1323333004/diff/1/mojo/tools/data/apptests#newcode83 mojo/tools/data/apptests:83: 'test': 'mojo:web_view_apptests', On 2015/09/09 18:20:46, msw wrote: > nit: ...
5 years, 3 months ago (2015-09-09 18:34:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323333004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323333004/20001
5 years, 3 months ago (2015-09-09 18:35:56 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-09 19:43:56 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/84fec63dbc6667f4c1e03eed4b6f11b4c9865a40 Cr-Commit-Position: refs/heads/master@{#347984}
5 years, 3 months ago (2015-09-09 19:44:29 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:02:17 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/84fec63dbc6667f4c1e03eed4b6f11b4c9865a40
Cr-Commit-Position: refs/heads/master@{#347984}

Powered by Google App Engine
This is Rietveld 408576698