Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1195623002: Reland: Run mojo unit tests on the Android main waterfall. (Closed)

Created:
5 years, 6 months ago by msw
Modified:
5 years, 6 months ago
Reviewers:
Dirk Pranke, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Run mojo unit tests on the Android main waterfall. The original CL broke the bot with this compile error: ninja:error: unknown target 'html_viewer_unittests_apk' This CL also renames the targets to their output names. (we could also fix *_apk target names, but this seems okay) Also add mojo_view_manager_lib_unittests to the list. Description from https://codereview.chromium.org/1145343005 Run Mojo additional unit tests on the "Android GN" bot: http://build.chromium.org/p/chromium.linux/builders/Android%20GN (No CQ yet; need Android GN testing support/devices there...) Add the necessary target mappings to ninja_to_gn.pyl Similar tests already run on Linux GN and our chromium.mojo FYI: http://build.chromium.org/p/chromium.linux/builders/Linux%20GN http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android BUG=478244, 359249 TEST=Steps run and pass on the bot. R=dpranke@chromium.org,sky@chromium.org Committed: https://crrev.com/056493c2718ee1017c6acf3c2bb8056e6c77731f Cr-Commit-Position: refs/heads/master@{#335293}

Patch Set 1 #

Patch Set 2 : Use full target names in BUILD.gn files. #

Patch Set 3 : Continue building the view_manager tests group in mandoline:tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -12 lines) Patch
M components/html_viewer/BUILD.gn View 1 1 chunk +1 line, -2 lines 0 comments Download
M components/resource_provider/BUILD.gn View 1 1 chunk +1 line, -2 lines 0 comments Download
M mandoline/BUILD.gn View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/runner/BUILD.gn View 1 1 chunk +1 line, -2 lines 0 comments Download
M mojo/shell/BUILD.gn View 1 1 chunk +1 line, -2 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 1 chunk +42 lines, -0 lines 0 comments Download
M testing/buildbot/ninja_to_gn.pyl View 1 4 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
msw
Hey Dirk, please take a look at testing/buildbot/*; thanks! Hey Scott, please take a look ...
5 years, 6 months ago (2015-06-19 00:06:18 UTC) #2
Dirk Pranke
lgtm
5 years, 6 months ago (2015-06-19 00:55:29 UTC) #3
sky
LGTM
5 years, 6 months ago (2015-06-19 03:52:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195623002/40001
5 years, 6 months ago (2015-06-19 07:14:40 UTC) #6
msw
I stopped the CQ from landing this, because some ipc_mojo_unittests timeout on Android. I filed ...
5 years, 6 months ago (2015-06-19 16:35:00 UTC) #8
msw
Okay, the FYI bot went green. I'll try landing this and keep a close eye ...
5 years, 6 months ago (2015-06-19 18:03:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195623002/40001
5 years, 6 months ago (2015-06-19 18:05:29 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-19 18:12:56 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 18:13:50 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/056493c2718ee1017c6acf3c2bb8056e6c77731f
Cr-Commit-Position: refs/heads/master@{#335293}

Powered by Google App Engine
This is Rietveld 408576698