Copy libvpx from DEPS to src

Copy libvpx from DEPS to src

Leaves the previous version in place but updates BUILD.gn and libvpx.gn to point to the new version. This allows decoupling the WebRTC update which is also in DEPS.

libvpx DEPS changes ac1772e:0d6551
https://codereview.chromium.org/1339033002
https://chromium-review.googlesource.com/299759
https://codereview.chromium.org/1350853003
https://codereview.chromium.org/1353433003

Copy directory to libvpx_new to avoid breaking bisecting. This allows the user to move between and older and newer revision. A followup to rename libvpx_new to libvpx will come in some ~months because there are additional complications if one tries to sync directly from pre-move to post-rename or the other way around.

Remove WATCHLISTS and codereview.settings from _new and use the parent versions.

Add DEPS file to enumerate the #include paths.

Check out third_party/libvpx_new/source/libvpx directly from upstream project

Update all the easy clients of libvpx to depend on the new tree directly.

https://chromium.googlesource.com/chromium/deps/libvpx/+/ac1772e3db5c885b554f6a72ca9dbac4245cb0e2

BUG=481034
R=tomfinegan@chromium.org,brettw@chromium.org,phajdan.jr@chromium.org

Committed: https://crrev.com/5238138a422157576799266228c0c9ee174936ae
Cr-Commit-Position: refs/heads/master@{#349789}

[Johann, 2015-09-03 19:54:51]

The CQ bit was checked by johannkoenig@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-03 19:55:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323333002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323333002/1

[commit-bot: I haz the power, 2015-09-03 19:58:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-03 19:58:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[blundell, 2015-09-10 10:09:54]

blundell@chromium.org changed reviewers:
+ blundell@chromium.org

[blundell, 2015-09-10 10:09:55]

https://codereview.chromium.org/1323333002/diff/1/DEPS
File DEPS (left):

https://codereview.chromium.org/1323333002/diff/1/DEPS#oldcode36
DEPS:36: 'libvpx_revision': 'a208ecae8e6fff1c0d4286bdc000d7c5efaab411',
It looks like the patch application is choking on replacing the BUILD.gn that
gets pulled in from DEPS with the BUILD.gn that this CL is adding. I'm not sure
how/whether this is supposed to work. One question: Do those two BUILD.gn files
have the same contents? If they don't, you could try again making sure that the
contents of all the files you're checking in are identical to the existing
contents in the tree. Beyond that, I don't have knowledge of how/whether it's
possible to have the trybots correctly handle the addition of a file that
already exists in the codebase but isn't checked in.

https://codereview.chromium.org/1323333002/diff/1/third_party/libvpx/source/c...
File third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vp8_rtcd.h
(right):

https://codereview.chromium.org/1323333002/diff/1/third_party/libvpx/source/c...
third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vp8_rtcd.h:1: #ifndef
VP8_RTCD_H_
This is not the usual structure. Ideally, you would have:

//third_party/libvpx/src [what gets pulled via DEPS]
//third_party/libvpx/<foo> [anything that's checked in to the tree, e.g.
"config"]

Is that not possible e.g. due to the way that the structure of includes works?

[Johann, 2015-09-10 16:42:24]

https://codereview.chromium.org/1323333002/diff/1/DEPS
File DEPS (left):

https://codereview.chromium.org/1323333002/diff/1/DEPS#oldcode36
DEPS:36: 'libvpx_revision': 'a208ecae8e6fff1c0d4286bdc000d7c5efaab411',
On 2015/09/10 10:09:55, blundell wrote:
>One question: Do those two BUILD.gn files
> have the same contents? If they don't, you could try again making sure that
the
> contents of all the files you're checking in are identical to the existing
> contents in the tree.

There are some differences. I started this with a previous version from what is
currently rolled. I will update and give it another shot.

https://codereview.chromium.org/1323333002/diff/1/third_party/libvpx/source/c...
File third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vp8_rtcd.h
(right):

https://codereview.chromium.org/1323333002/diff/1/third_party/libvpx/source/c...
third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vp8_rtcd.h:1: #ifndef
VP8_RTCD_H_
On 2015/09/10 10:09:55, blundell wrote:
> This is not the usual structure. Ideally, you would have:
> 
> //third_party/libvpx/src [what gets pulled via DEPS]
> //third_party/libvpx/<foo> [anything that's checked in to the tree, e.g.
> "config"]
> 
> Is that not possible e.g. due to the way that the structure of includes works?

I have not investigated any other options. I've been running with what was
already set up. Up for moving things around.

[Johann, 2015-09-10 22:45:32]

On 2015/09/10 16:42:24, Johann wrote:
> https://codereview.chromium.org/1323333002/diff/1/DEPS
> File DEPS (left):
> 
> https://codereview.chromium.org/1323333002/diff/1/DEPS#oldcode36
> DEPS:36: 'libvpx_revision': 'a208ecae8e6fff1c0d4286bdc000d7c5efaab411',
> On 2015/09/10 10:09:55, blundell wrote:
> >One question: Do those two BUILD.gn files
> > have the same contents? If they don't, you could try again making sure that
> the
> > contents of all the files you're checking in are identical to the existing
> > contents in the tree.
> 
> There are some differences. I started this with a previous version from what
is
> currently rolled. I will update and give it another shot.

Fresh version does not appear to help. Should I make third_party/libvpx.new,
switch everything to depend on that, remove third_party/libvpx, and move it
over?

[blundell, 2015-09-11 05:30:30]

On 2015/09/10 22:45:32, Johann wrote:
> On 2015/09/10 16:42:24, Johann wrote:
> > https://codereview.chromium.org/1323333002/diff/1/DEPS
> > File DEPS (left):
> > 
> > https://codereview.chromium.org/1323333002/diff/1/DEPS#oldcode36
> > DEPS:36: 'libvpx_revision': 'a208ecae8e6fff1c0d4286bdc000d7c5efaab411',
> > On 2015/09/10 10:09:55, blundell wrote:
> > >One question: Do those two BUILD.gn files
> > > have the same contents? If they don't, you could try again making sure
that
> > the
> > > contents of all the files you're checking in are identical to the existing
> > > contents in the tree.
> > 
> > There are some differences. I started this with a previous version from what
> is
> > currently rolled. I will update and give it another shot.
> 
> Fresh version does not appear to help. Should I make third_party/libvpx.new,
> switch everything to depend on that, remove third_party/libvpx, and move it
> over?

I would pose the question explicitly on chromium-dev@ first to see if anyone has
a lower-overhead solution. Someone must have faced this problem before.

[Johann, 2015-09-15 21:58:51]

The CQ bit was checked by johannkoenig@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-15 21:59:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323333002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323333002/80001

[commit-bot: I haz the power, 2015-09-15 22:10:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-15 22:10:57]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Johann, 2015-09-15 22:56:00]

So anything that wasn't building webrtc seems to have gone through. With webrtc,
duplicate definitions for libvpx and libvpx_new. I should be able to fix this by
tweaking webrtc and rolling it at the same time. Otherwise things seem OK-ish?

[Johann, 2015-09-15 23:41:14]

Newest approach: keep libvpx directory but only point the BUILD.gn and
libvpx.gyp targets at libvpx_new. WebRTC can can be updated later, at which
point libvpx can be removed. After a cooling-off period, libvpx_new can be
renamed. Or not, I'm not particularly concerned.

[Johann, 2015-09-15 23:52:53]

AAAAAAAAAAAAARGRGHRTH include paths need updating too.

[Johann, 2015-09-16 21:45:40]

The CQ bit was checked by johannkoenig@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-16 21:46:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323333002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323333002/140001

[commit-bot: I haz the power, 2015-09-16 22:51:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-16 22:51:31]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Johann, 2015-09-17 16:32:16]

johannkoenig@google.com changed reviewers:
+ brettw@chromium.org, pkasting@chromium.org, thakis@chromium.org

[Johann, 2015-09-17 16:32:18]

This appears complete to me outside of the presubmit warning regarding include
order. I was trying to touch as little as possible (although going on that idea,
I should revert all deps changes and do them later - also a possibility). Let me
know if that should be changed now.

This copies libvpx to libvpx_new and rewrites BUILD.gn and libpvx.gn in the old
directory to depend on the new location and pass the include paths through.

Currently libvpx and libvpx_new are very close - a meld shows changes to DEPS,
codereview.settings, generate_gypi.sh (use new path), BUILD.gn and libvpx.gyp.
The upstream vp10 directory, which we had been deleting as part of the import,
also shows up now but continues to be unused.

After this is landed there are some things to do. Most importantly: update
webrtc to depend directly on libvpx_new and delete libvpx. libvpx_srcs.gni needs
some tidying to pass the linter cleanly. This will come as the scripts
(update_libvpx.sh, generate_gypi.sh) are updated to reflect the new roll
procedure.

https://codereview.chromium.org/1323333002/diff/140001/media/filters/vpx_vide...
File media/filters/vpx_video_decoder.cc (right):

https://codereview.chromium.org/1323333002/diff/140001/media/filters/vpx_vide...
media/filters/vpx_video_decoder.cc:41: #include
"third_party/libvpx_new/source/libvpx/vpx/vp8dx.h"
presubmit would like vp8 before vpx

https://codereview.chromium.org/1323333002/diff/140001/remoting/codec/video_d...
File remoting/codec/video_decoder_vpx.cc (right):

https://codereview.chromium.org/1323333002/diff/140001/remoting/codec/video_d...
remoting/codec/video_decoder_vpx.cc:20: #include
"third_party/libvpx_new/source/libvpx/vpx/vp8dx.h"
presubmit would like vp8 before vpx

https://codereview.chromium.org/1323333002/diff/140001/remoting/codec/video_e...
File remoting/codec/video_encoder_vpx.cc (right):

https://codereview.chromium.org/1323333002/diff/140001/remoting/codec/video_e...
remoting/codec/video_encoder_vpx.cc:20: #include
"third_party/libvpx_new/source/libvpx/vpx/vp8cx.h"
presubmit would like vp8 before vpx

[Johann, 2015-09-18 12:44:08]

Peter Kasting, Nico, brettw, if you could take a look I would appreciate it.

[Tom Finegan, 2015-09-18 17:41:12]

On 2015/09/18 12:44:08, Johann wrote:
> Peter Kasting, Nico, brettw, if you could take a look I would appreciate it.

libvpx lgtm

[Johann, 2015-09-18 17:41:52]

The CQ bit was checked by johannkoenig@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-18 17:42:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323333002/150001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323333002/150001

[commit-bot: I haz the power, 2015-09-18 18:07:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-18 18:07:06]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Johann, 2015-09-18 21:09:19]

Not sure why win_chromium_rel_ng and win_chromium_x64_rel_ng are showing red at
the front of the list. I re-ran them and they passed, and show up at the end of
the list under 'More>>>'

As a carrot, once this is merged I can work on
https://code.google.com/p/webm/issues/detail?id=969

[brettw, 2015-09-18 21:16:42]

lgtm

[Johann, 2015-09-18 21:23:32]

The CQ bit was checked by johannkoenig@google.com

[commit-bot: I haz the power, 2015-09-18 21:23:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323333002/150001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323333002/150001

[Johann, 2015-09-18 21:35:11]

johannkoenig@google.com changed reviewers:
+ phajdan.jr@chromium.org

[Johann, 2015-09-18 21:35:12]

phajdan.jr@chromium.org for tools/checklicenses and tools/copyright_scanner

They're being updated to reflect the new location for libvpx

[commit-bot: I haz the power, 2015-09-18 21:42:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-18 21:42:45]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Paweł Hajdan Jr., 2015-09-18 22:16:33]

LGTM

[Johann, 2015-09-18 22:22:20]

The CQ bit was checked by johannkoenig@google.com

[commit-bot: I haz the power, 2015-09-18 22:22:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323333002/150001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323333002/150001

[commit-bot: I haz the power, 2015-09-18 22:35:32]

Committed patchset #16 (id:150001)

[commit-bot: I haz the power, 2015-09-18 22:36:06]

Patchset 16 (id:??) landed as
https://crrev.com/5238138a422157576799266228c0c9ee174936ae
Cr-Commit-Position: refs/heads/master@{#349789}