Issue 1353433003: Add coma

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1353433003: Add coma (Closed)

Created:
5 years, 3 months ago by Johann

Modified:
5 years, 2 months ago

Reviewers:
Tom Finegan

CC:
chromium-reviews, wwcv, jzern, fgalligan1

Base URL:
https://chromium.googlesource.com/chromium/deps/libvpx.git@master

Target Ref:
refs/heads/master

Project:
chromium_deps

Visibility:
Public.

More Reviews

Description

Add coma Linux doesn't seem to care but Mac does? Also use DEPTH for path like the dependency. Not sure if it's a good idea. TBR=tomfinegan@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/libvpx/+/0d6551cd1e1359423a7f4af503472d280437e9bb

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	libvpx.gyp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Johann

Committed patchset #1 (id:1) manually as 0d6551cd1e1359423a7f4af503472d280437e9bb (presubmit successful).

5 years, 3 months ago (2015-09-16 19:20:36 UTC) #1

Tom Finegan

5 years, 2 months ago (2015-09-29 17:11:11 UTC) #2

Message was sent while issue was closed.

On 2015/09/16 19:20:36, Johann wrote:
> Committed patchset #1 (id:1) manually as
> 0d6551cd1e1359423a7f4af503472d280437e9bb (presubmit successful).

lgtm

Expand Messages | Collapse Messages